summaryrefslogtreecommitdiff
path: root/Userland/Libraries/LibWeb/DOM
diff options
context:
space:
mode:
authorLinus Groh <mail@linusgroh.de>2023-04-13 00:47:15 +0200
committerLinus Groh <mail@linusgroh.de>2023-04-13 14:29:42 +0200
commitb84f8fb55b2f926970af1d657314bb82a905ae1d (patch)
treebef32f893a3077f71b29e955fbf036602e6e83e5 /Userland/Libraries/LibWeb/DOM
parented9e2366da6a28ad39bf6f71d70201d59fa79220 (diff)
downloadserenity-b84f8fb55b2f926970af1d657314bb82a905ae1d.zip
LibJS: Make intrinsics getters return NonnullGCPtr
Some of these are allocated upon initialization of the intrinsics, and some lazily, but in neither case the getters actually return a nullptr. This saves us a whole bunch of pointer dereferences (as NonnullGCPtr has an `operator T&()`), and also has the interesting side effect of forcing us to explicitly use the FunctionObject& overload of call(), as passing a NonnullGCPtr is ambigous - it could implicitly be turned into a Value _or_ a FunctionObject& (so we have to dereference manually).
Diffstat (limited to 'Userland/Libraries/LibWeb/DOM')
-rw-r--r--Userland/Libraries/LibWeb/DOM/IDLEventListener.cpp2
-rw-r--r--Userland/Libraries/LibWeb/DOM/NodeFilter.cpp2
2 files changed, 2 insertions, 2 deletions
diff --git a/Userland/Libraries/LibWeb/DOM/IDLEventListener.cpp b/Userland/Libraries/LibWeb/DOM/IDLEventListener.cpp
index 685a7fdcd4..18b5481fd7 100644
--- a/Userland/Libraries/LibWeb/DOM/IDLEventListener.cpp
+++ b/Userland/Libraries/LibWeb/DOM/IDLEventListener.cpp
@@ -14,7 +14,7 @@ WebIDL::ExceptionOr<JS::NonnullGCPtr<IDLEventListener>> IDLEventListener::create
}
IDLEventListener::IDLEventListener(JS::Realm& realm, JS::NonnullGCPtr<WebIDL::CallbackType> callback)
- : JS::Object(ConstructWithPrototypeTag::Tag, *realm.intrinsics().object_prototype())
+ : JS::Object(ConstructWithPrototypeTag::Tag, realm.intrinsics().object_prototype())
, m_callback(move(callback))
{
}
diff --git a/Userland/Libraries/LibWeb/DOM/NodeFilter.cpp b/Userland/Libraries/LibWeb/DOM/NodeFilter.cpp
index a667615ba6..8342de9dc8 100644
--- a/Userland/Libraries/LibWeb/DOM/NodeFilter.cpp
+++ b/Userland/Libraries/LibWeb/DOM/NodeFilter.cpp
@@ -16,7 +16,7 @@ WebIDL::ExceptionOr<JS::NonnullGCPtr<NodeFilter>> NodeFilter::create(JS::Realm&
}
NodeFilter::NodeFilter(JS::Realm& realm, WebIDL::CallbackType& callback)
- : PlatformObject(*realm.intrinsics().object_prototype())
+ : PlatformObject(realm.intrinsics().object_prototype())
, m_callback(callback)
{
}