diff options
| author | Timothy Flynn <trflynn89@pm.me> | 2023-01-10 06:28:20 -0500 |
|---|---|---|
| committer | Andreas Kling <kling@serenityos.org> | 2023-01-10 16:08:14 +0100 |
| commit | 834202aeb9a47c544ab4e61deb813de50bc03946 (patch) | |
| tree | c120e9231fa5451b527131f6e423fac2645253bb /Userland/Libraries/LibWeb/Bindings | |
| parent | 7bd8fd000f3f8e92ff632be2370a279ac2309250 (diff) | |
| download | serenity-834202aeb9a47c544ab4e61deb813de50bc03946.zip | |
LibWeb: Move setting of Web object prototypes to initialize()
This needs to happen before prototype/constructor intitialization can be
made lazy. Otherwise, GC could run during the C++ constructor and try to
collect the object currently being created.
Diffstat (limited to 'Userland/Libraries/LibWeb/Bindings')
| -rw-r--r-- | Userland/Libraries/LibWeb/Bindings/LocationObject.cpp | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/Userland/Libraries/LibWeb/Bindings/LocationObject.cpp b/Userland/Libraries/LibWeb/Bindings/LocationObject.cpp index ae44fe8c33..a9a65d4940 100644 --- a/Userland/Libraries/LibWeb/Bindings/LocationObject.cpp +++ b/Userland/Libraries/LibWeb/Bindings/LocationObject.cpp @@ -24,7 +24,6 @@ namespace Web::Bindings { LocationObject::LocationObject(JS::Realm& realm) : PlatformObject(realm) { - set_prototype(&cached_web_prototype(realm, "Location")); } LocationObject::~LocationObject() = default; @@ -41,6 +40,8 @@ void LocationObject::initialize(JS::Realm& realm) auto& vm = this->vm(); Object::initialize(realm); + set_prototype(&ensure_web_prototype<LocationPrototype>(realm, "Location")); + u8 attr = JS::Attribute::Writable | JS::Attribute::Enumerable; define_native_accessor(realm, "href", href_getter, href_setter, attr); define_native_accessor(realm, "host", host_getter, {}, attr); |