Everywhere: Convert ByteBuffer factory methods from Optional -> ErrorOr

Apologies for the enormous commit, but I don't see a way to split this
up nicely. In the vast majority of cases it's a simple change. A few
extra places can use TRY instead of manual error checking though. :^)

1 files changed, 3 insertions, 3 deletions

diff --git a/Userland/Libraries/LibWeb/Bindings/IDLAbstractOperations.cpp b/Userland/Libraries/LibWeb/Bindings/IDLAbstractOperations.cpp
index cc0888e5e2..180d936d39 100644
--- a/Userland/Libraries/LibWeb/Bindings/IDLAbstractOperations.cpp
+++ b/Userland/Libraries/LibWeb/Bindings/IDLAbstractOperations.cpp
@@ -109,17 +109,17 @@ Optional<ByteBuffer> get_buffer_source_copy(JS::Object const& buffer_source)
 
     // 8. Let bytes be a new byte sequence of length equal to length.
     auto bytes = ByteBuffer::create_zeroed(length);
-    if (!bytes.has_value())
+    if (bytes.is_error())
         return {};
 
     // 9. For i in the range offset to offset + length − 1, inclusive, set bytes[i − offset] to ! GetValueFromBuffer(esArrayBuffer, i, Uint8, true, Unordered).
     for (u64 i = offset; i <= offset + length - 1; ++i) {
         auto value = es_array_buffer->get_value<u8>(i, true, JS::ArrayBuffer::Unordered);
-        (*bytes)[i - offset] = (u8)value.as_u32();
+        bytes.value()[i - offset] = (u8)value.as_u32();
     }
 
     // 10. Return bytes.
-    return bytes;
+    return bytes.release_value();
 }
 
 }