diff options
| author | Andrew Kaster <akaster@serenityos.org> | 2022-09-30 20:11:51 -0600 |
|---|---|---|
| committer | Linus Groh <mail@linusgroh.de> | 2022-10-01 21:05:32 +0100 |
| commit | 691a7070f414238c0e9830899a0e750af9b00e1e (patch) | |
| tree | 89c6da7972f8a0693ffec137a29181bdedfc3558 /Userland/Libraries/LibWeb/Bindings/MainThreadVM.h | |
| parent | 56b381aac0db837b1b840c482edd9a8d67c2600e (diff) | |
| download | serenity-691a7070f414238c0e9830899a0e750af9b00e1e.zip | |
LibWeb: Remove the internal window object from WebEngineCustomData
Now that no one needs a Window just to create prototypes, we can remove
the internal window Object from the main thread VM and get rid of the
HTML::Window include for it.
This finally solves the reference binding to nullptr error in ladybird
that shows up when compiling it with ASAN.
Diffstat (limited to 'Userland/Libraries/LibWeb/Bindings/MainThreadVM.h')
| -rw-r--r-- | Userland/Libraries/LibWeb/Bindings/MainThreadVM.h | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/Userland/Libraries/LibWeb/Bindings/MainThreadVM.h b/Userland/Libraries/LibWeb/Bindings/MainThreadVM.h index 62eef59b66..a445ee7e4c 100644 --- a/Userland/Libraries/LibWeb/Bindings/MainThreadVM.h +++ b/Userland/Libraries/LibWeb/Bindings/MainThreadVM.h @@ -13,7 +13,6 @@ #include <LibJS/Runtime/VM.h> #include <LibWeb/DOM/MutationObserver.h> #include <LibWeb/HTML/EventLoop/EventLoop.h> -#include <LibWeb/HTML/Window.h> namespace Web::Bindings { @@ -34,10 +33,6 @@ struct WebEngineCustomData final : public JS::VM::CustomData { Vector<JS::Handle<DOM::MutationObserver>> mutation_observers; OwnPtr<JS::ExecutionContext> root_execution_context; - - // This object is used as the global object for GC-allocated objects that don't - // belong to a web-facing global object. - JS::Handle<HTML::Window> internal_window_object; }; struct WebEngineCustomJobCallbackData final : public JS::JobCallback::CustomData { @@ -55,7 +50,6 @@ struct WebEngineCustomJobCallbackData final : public JS::JobCallback::CustomData HTML::ClassicScript* active_script(); JS::VM& main_thread_vm(); -HTML::Window& main_thread_internal_window_object(); void queue_mutation_observer_microtask(DOM::Document&); NonnullOwnPtr<JS::ExecutionContext> create_a_new_javascript_realm(JS::VM&, Function<JS::Object*(JS::Realm&)> create_global_object, Function<JS::Object*(JS::Realm&)> create_global_this_value); |