diff options
| author | davidot <davidot@serenityos.org> | 2022-02-04 16:12:39 +0100 |
|---|---|---|
| committer | Andreas Kling <kling@serenityos.org> | 2022-02-05 11:52:51 +0100 |
| commit | 8da6c01d8f7b24d63431ceef1db62c2e2cdcc2bd (patch) | |
| tree | 3145d43790cd6efc635c1c94419666fb76bcf724 /Userland/Libraries/LibTest | |
| parent | 794d79e3152111776f9e2394bb5fd35f062f5212 (diff) | |
| download | serenity-8da6c01d8f7b24d63431ceef1db62c2e2cdcc2bd.zip | |
LibJS: Remove the JS_TRACK_ZOMBIE_CELLS option
This feature had bitrotted somewhat and would trigger errors because
PrimitiveStrings were "destroyed" but because of this mode they were not
removed from the string cache. Even fixing that case running test-js
with the options still failed in more places.
Diffstat (limited to 'Userland/Libraries/LibTest')
| -rw-r--r-- | Userland/Libraries/LibTest/JavaScriptTestRunner.h | 7 | ||||
| -rw-r--r-- | Userland/Libraries/LibTest/JavaScriptTestRunnerMain.cpp | 6 |
2 files changed, 0 insertions, 13 deletions
diff --git a/Userland/Libraries/LibTest/JavaScriptTestRunner.h b/Userland/Libraries/LibTest/JavaScriptTestRunner.h index 6dff4cb26d..f126409ca9 100644 --- a/Userland/Libraries/LibTest/JavaScriptTestRunner.h +++ b/Userland/Libraries/LibTest/JavaScriptTestRunner.h @@ -116,9 +116,6 @@ static consteval size_t __testjs_last() static constexpr auto TOP_LEVEL_TEST_NAME = "__$$TOP_LEVEL$$__"; extern RefPtr<JS::VM> g_vm; extern bool g_collect_on_every_allocation; -#ifdef JS_TRACK_ZOMBIE_CELLS -extern bool g_zombify_dead_cells; -#endif extern bool g_run_bytecode; extern String g_currently_running_test; struct FunctionWithLength { @@ -291,10 +288,6 @@ inline JSFileResult TestRunner::run_file_test(const String& test_path) interpreter->heap().set_should_collect_on_every_allocation(g_collect_on_every_allocation); -#ifdef JS_TRACK_ZOMBIE_CELLS - interpreter->heap().set_zombify_dead_cells(g_zombify_dead_cells); -#endif - if (g_run_file) { auto result = g_run_file(test_path, *interpreter); if (result.is_error() && result.error() == RunFileHookResult::SkipFile) { diff --git a/Userland/Libraries/LibTest/JavaScriptTestRunnerMain.cpp b/Userland/Libraries/LibTest/JavaScriptTestRunnerMain.cpp index a4aa7f7e44..0910486bb2 100644 --- a/Userland/Libraries/LibTest/JavaScriptTestRunnerMain.cpp +++ b/Userland/Libraries/LibTest/JavaScriptTestRunnerMain.cpp @@ -19,9 +19,6 @@ namespace JS { RefPtr<::JS::VM> g_vm; bool g_collect_on_every_allocation = false; -#ifdef JS_TRACK_ZOMBIE_CELLS -bool g_zombify_dead_cells = false; -#endif bool g_run_bytecode = false; String g_currently_running_test; HashMap<String, FunctionWithLength> s_exposed_global_functions; @@ -112,9 +109,6 @@ int main(int argc, char** argv) }); args_parser.add_option(print_json, "Show results as JSON", "json", 'j'); args_parser.add_option(g_collect_on_every_allocation, "Collect garbage after every allocation", "collect-often", 'g'); -#ifdef JS_TRACK_ZOMBIE_CELLS - args_parser.add_option(g_zombify_dead_cells, "Zombify dead cells (to catch missing GC marks)", "zombify-dead-cells", 'z'); -#endif args_parser.add_option(g_run_bytecode, "Use the bytecode interpreter", "run-bytecode", 'b'); args_parser.add_option(JS::Bytecode::g_dump_bytecode, "Dump the bytecode", "dump-bytecode", 'd'); args_parser.add_option(test_glob, "Only run tests matching the given glob", "filter", 'f', "glob"); |