LibSyntax+LibGUI+LibJS: Move JS syntax highlighter to LibJS

This is a little bit messy but the basic idea is:

Syntax::Highlighter now has a Syntax::HighlighterClient to talk to the
outside world. It mostly communicates in LibGUI primitives that are
available in headers, so inlineable.

GUI::TextEditor inherits from Syntax::HighlighterClient.

This let us to move GUI::JSSyntaxHighlighter to JS::SyntaxHighlighter
and remove LibGUI's dependency on LibJS.

1 files changed, 4 insertions, 2 deletions

diff --git a/Userland/Libraries/LibSyntax/Highlighter.h b/Userland/Libraries/LibSyntax/Highlighter.h
index 8ac7b2691c..4f56fc05d5 100644
--- a/Userland/Libraries/LibSyntax/Highlighter.h
+++ b/Userland/Libraries/LibSyntax/Highlighter.h
@@ -30,6 +30,7 @@
 #include <AK/WeakPtr.h>
 #include <LibGUI/TextDocument.h>
 #include <LibGfx/Palette.h>
+#include <LibSyntax/HighlighterClient.h>
 
 namespace Syntax {
 
@@ -61,14 +62,15 @@ public:
     virtual bool is_identifier(void*) const { return false; };
     virtual bool is_navigatable(void*) const { return false; };
 
-    void attach(GUI::TextEditor& editor);
+    void attach(HighlighterClient&);
     void detach();
     void cursor_did_change();
 
 protected:
     Highlighter() { }
 
-    WeakPtr<GUI::TextEditor> m_editor;
+    // FIXME: This should be WeakPtr somehow
+    HighlighterClient* m_client { nullptr };
 
     struct MatchingTokenPair {
         void* open;