LibSQL: Make TupleDescriptor a shared pointer instead of a stack object

Tuple descriptors are basically the same for for example all rows in
a table. Makes sense to share them instead of copying them for every
single row.

1 files changed, 6 insertions, 5 deletions

diff --git a/Userland/Libraries/LibSQL/Key.h b/Userland/Libraries/LibSQL/Key.h
index 7a3cb8beab..edc12a40b7 100644
--- a/Userland/Libraries/LibSQL/Key.h
+++ b/Userland/Libraries/LibSQL/Key.h
@@ -14,16 +14,17 @@ namespace SQL {
 
 class Key : public Tuple {
 public:
-    Key() = default;
-    explicit Key(TupleDescriptor const&);
-    explicit Key(RefPtr<IndexDef>);
-    Key(TupleDescriptor const&, ByteBuffer&, size_t& offset);
+    Key();
+    explicit Key(NonnullRefPtr<TupleDescriptor> const&);
+    explicit Key(NonnullRefPtr<IndexDef>);
+    Key(NonnullRefPtr<TupleDescriptor> const&, ByteBuffer&, size_t& offset);
     Key(RefPtr<IndexDef>, ByteBuffer&, size_t& offset);
+    Key(Key const&) = default;
     RefPtr<IndexDef> index() const { return m_index; }
     [[nodiscard]] virtual size_t data_length() const override { return Tuple::data_length() + sizeof(u32); }
 
 private:
-    RefPtr<IndexDef> m_index;
+    RefPtr<IndexDef> m_index { nullptr };
 };
 
 }