LibJS: Use empty value for Reference unresolvable state, not undefined

This fixes an issue where `undefined.foo = "bar"` would throw a
ReferenceError instead of a TypeError as undefined was also used for
truly unresolvable references (e.g. `foo() = "bar"`). I also made the
various error messages here a bit nicer, just "primitive value" is not
very helpful.

1 files changed, 16 insertions, 2 deletions

diff --git a/Userland/Libraries/LibJS/Tests/strict-mode-errors.js b/Userland/Libraries/LibJS/Tests/strict-mode-errors.js
index ada52e359f..8c8d756c4f 100644
--- a/Userland/Libraries/LibJS/Tests/strict-mode-errors.js
+++ b/Userland/Libraries/LibJS/Tests/strict-mode-errors.js
@@ -4,12 +4,26 @@ test("basic functionality", () => {
     [true, false, "foo", 123].forEach(primitive => {
         expect(() => {
             primitive.foo = "bar";
-        }).toThrowWithMessage(TypeError, "Cannot assign property foo to primitive value");
+        }).toThrowWithMessage(
+            TypeError,
+            `Cannot set property 'foo' of ${typeof primitive} '${primitive}'`
+        );
+        expect(() => {
+            primitive[Symbol.hasInstance] = 123;
+        }).toThrowWithMessage(
+            TypeError,
+            `Cannot set property 'Symbol(Symbol.hasInstance)' of ${typeof primitive} '${primitive}'`
+        );
+    });
+    [null, undefined].forEach(primitive => {
+        expect(() => {
+            primitive.foo = "bar";
+        }).toThrowWithMessage(TypeError, `Cannot set property 'foo' of ${primitive}`);
         expect(() => {
             primitive[Symbol.hasInstance] = 123;
         }).toThrowWithMessage(
             TypeError,
-            "Cannot assign property Symbol(Symbol.hasInstance) to primitive value"
+            `Cannot set property 'Symbol(Symbol.hasInstance)' of ${primitive}`
         );
     });
 });