diff options
author | Linus Groh <mail@linusgroh.de> | 2022-08-16 20:33:17 +0100 |
---|---|---|
committer | Linus Groh <mail@linusgroh.de> | 2022-08-23 13:58:30 +0100 |
commit | f3117d46dc872a2d0f57273293b5691777b06279 (patch) | |
tree | d16e8d78bfc9c94e3e6d4188f8a853a148b2b5c8 /Userland/Libraries/LibJS/Runtime/JSONObject.cpp | |
parent | 5398dcc55e1b8279f6b3edf62ad249a27b4f2f64 (diff) | |
download | serenity-f3117d46dc872a2d0f57273293b5691777b06279.zip |
LibJS: Remove GlobalObject from VM::throw_completion()
This is a continuation of the previous five commits.
A first big step into the direction of no longer having to pass a realm
(or currently, a global object) trough layers upon layers of AOs!
Unlike the create() APIs we can safely assume that this is only ever
called when a running execution context and therefore current realm
exists. If not, you can always manually allocate the Error and put it in
a Completion :^)
In the spec, throw exceptions implicitly use the current realm's
intrinsics as well: https://tc39.es/ecma262/#sec-throw-an-exception
Diffstat (limited to 'Userland/Libraries/LibJS/Runtime/JSONObject.cpp')
-rw-r--r-- | Userland/Libraries/LibJS/Runtime/JSONObject.cpp | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/Userland/Libraries/LibJS/Runtime/JSONObject.cpp b/Userland/Libraries/LibJS/Runtime/JSONObject.cpp index e11291d05f..ef60a2e792 100644 --- a/Userland/Libraries/LibJS/Runtime/JSONObject.cpp +++ b/Userland/Libraries/LibJS/Runtime/JSONObject.cpp @@ -200,7 +200,7 @@ ThrowCompletionOr<String> JSONObject::serialize_json_property(GlobalObject& glob // 10. If Type(value) is BigInt, throw a TypeError exception. if (value.is_bigint()) - return vm.throw_completion<TypeError>(global_object, ErrorType::JsonBigInt); + return vm.throw_completion<TypeError>(ErrorType::JsonBigInt); // 11. If Type(value) is Object and IsCallable(value) is false, then if (value.is_object() && !value.is_function()) { @@ -224,7 +224,7 @@ ThrowCompletionOr<String> JSONObject::serialize_json_object(GlobalObject& global { auto& vm = global_object.vm(); if (state.seen_objects.contains(&object)) - return vm.throw_completion<TypeError>(global_object, ErrorType::JsonCircular); + return vm.throw_completion<TypeError>(ErrorType::JsonCircular); state.seen_objects.set(&object); String previous_indent = state.indent; @@ -293,7 +293,7 @@ ThrowCompletionOr<String> JSONObject::serialize_json_array(GlobalObject& global_ { auto& vm = global_object.vm(); if (state.seen_objects.contains(&object)) - return vm.throw_completion<TypeError>(global_object, ErrorType::JsonCircular); + return vm.throw_completion<TypeError>(ErrorType::JsonCircular); state.seen_objects.set(&object); String previous_indent = state.indent; @@ -401,7 +401,7 @@ JS_DEFINE_NATIVE_FUNCTION(JSONObject::parse) auto json = JsonValue::from_string(string); if (json.is_error()) - return vm.throw_completion<SyntaxError>(global_object, ErrorType::JsonMalformed); + return vm.throw_completion<SyntaxError>(ErrorType::JsonMalformed); Value unfiltered = parse_json_value(global_object, json.value()); if (reviver.is_function()) { auto* root = Object::create(realm, global_object.object_prototype()); |