summaryrefslogtreecommitdiff
path: root/Userland/Libraries/LibJS/Runtime/Array.cpp
diff options
context:
space:
mode:
authorLinus Groh <mail@linusgroh.de>2021-06-13 00:22:35 +0100
committerLinus Groh <mail@linusgroh.de>2021-06-13 00:33:28 +0100
commit7327a28ccc5d5d17f2f24da02b93f43ce92e2d31 (patch)
tree3ecb66481aa7cf756bfb345d242b22dee1f9d641 /Userland/Libraries/LibJS/Runtime/Array.cpp
parent322c8a3995e3fab7c77b78b60348337e24a2d9e2 (diff)
downloadserenity-7327a28ccc5d5d17f2f24da02b93f43ce92e2d31.zip
LibJS: Add ECMA-262 section/title/URL comments almost everywhere
As mentioned on Discord earlier, we'll add these to all new functions going forward - this is the backfill. Reasons: - It makes you look at the spec, implementing based on MDN or V8 behavior is a no-go - It makes finding the various functions that are non-compliant easier, in the future everything should either have such a comment or, if it's not from the spec at all, a comment explaining why that is the case - It makes it easier to check whether a certain abstract operation is implemented in LibJS, not all of them use the same name as the spec. E.g. RejectPromise() is Promise::reject() - It makes it easier to reason about vm.arguments(), e.g. when the function has a rest parameter - It makes it easier to see whether a certain function is from a proposal or Annex B Also: - Add arguments to all functions and abstract operations that already had a comment - Fix some outdated section numbers - Replace some ecma-international.org URLs with tc39.es
Diffstat (limited to 'Userland/Libraries/LibJS/Runtime/Array.cpp')
-rw-r--r--Userland/Libraries/LibJS/Runtime/Array.cpp11
1 files changed, 6 insertions, 5 deletions
diff --git a/Userland/Libraries/LibJS/Runtime/Array.cpp b/Userland/Libraries/LibJS/Runtime/Array.cpp
index d8ab3b4236..232a5a42e2 100644
--- a/Userland/Libraries/LibJS/Runtime/Array.cpp
+++ b/Userland/Libraries/LibJS/Runtime/Array.cpp
@@ -12,9 +12,10 @@
namespace JS {
-// 10.4.2.2 ArrayCreate, https://tc39.es/ecma262/#sec-arraycreate
+// 10.4.2.2 ArrayCreate ( length [ , proto ] ), https://tc39.es/ecma262/#sec-arraycreate
Array* Array::create(GlobalObject& global_object, size_t length)
{
+ // FIXME: Support proto parameter
if (length > NumericLimits<u32>::max()) {
auto& vm = global_object.vm();
vm.throw_exception<RangeError>(global_object, ErrorType::InvalidLength, "array");
@@ -25,12 +26,12 @@ Array* Array::create(GlobalObject& global_object, size_t length)
return array;
}
-// 7.3.17 CreateArrayFromList, https://tc39.es/ecma262/#sec-createarrayfromlist
-Array* Array::create_from(GlobalObject& global_object, const Vector<Value>& values)
+// 7.3.17 CreateArrayFromList ( elements ), https://tc39.es/ecma262/#sec-createarrayfromlist
+Array* Array::create_from(GlobalObject& global_object, const Vector<Value>& elements)
{
auto* array = Array::create(global_object);
- for (size_t i = 0; i < values.size(); ++i)
- array->define_property(i, values[i]);
+ for (size_t i = 0; i < elements.size(); ++i)
+ array->define_property(i, elements[i]);
return array;
}