diff options
author | Hendiadyoin1 <leon.a@serenityos.org> | 2022-10-30 12:28:57 +0100 |
---|---|---|
committer | Andreas Kling <kling@serenityos.org> | 2022-11-01 11:21:18 +0100 |
commit | c9e7d452c5e152dbc30f65a7095aaf21511a6c71 (patch) | |
tree | 8bc40ff73845c2df0d3d10bc9756eae5f6604bc6 /Userland/Libraries/LibJS/Bytecode | |
parent | c66284ab0bd1c9cdc42f50e70c88c6e79819660c (diff) | |
download | serenity-c9e7d452c5e152dbc30f65a7095aaf21511a6c71.zip |
LibJS: Add a note about inaccuracies to UnifySameBlocks
Diffstat (limited to 'Userland/Libraries/LibJS/Bytecode')
-rw-r--r-- | Userland/Libraries/LibJS/Bytecode/Pass/UnifySameBlocks.cpp | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/Userland/Libraries/LibJS/Bytecode/Pass/UnifySameBlocks.cpp b/Userland/Libraries/LibJS/Bytecode/Pass/UnifySameBlocks.cpp index 70be9244e2..184c3fe86c 100644 --- a/Userland/Libraries/LibJS/Bytecode/Pass/UnifySameBlocks.cpp +++ b/Userland/Libraries/LibJS/Bytecode/Pass/UnifySameBlocks.cpp @@ -29,6 +29,8 @@ void UnifySameBlocks::perform(PassPipelineExecutable& executable) continue; auto candidate_bytes = candidate_block->instruction_stream(); + // FIXME: NewBigInt's value is not correctly reflected by its encoding in memory, + // this will yield false negatives for blocks containing that if (memcmp(candidate_bytes.data(), block_bytes.data(), candidate_block->size()) == 0) equal_blocks.set(&*candidate_block, &block); } |