diff options
author | Ali Mohammad Pur <ali.mpfard@gmail.com> | 2021-09-30 12:19:54 +0330 |
---|---|---|
committer | Andreas Kling <kling@serenityos.org> | 2021-09-30 11:46:37 +0200 |
commit | b0a9c5673e7a8a100ddd827b780abe7d284802c1 (patch) | |
tree | 282c91f61d3f2f11f8661a193a27a8e4a7fc5ad8 /Userland/Libraries/LibHTTP/HttpJob.cpp | |
parent | d16131b100aaf74e2d69207aea2c8a586bec6f1e (diff) | |
download | serenity-b0a9c5673e7a8a100ddd827b780abe7d284802c1.zip |
LibHTTP: Respect the 'Connection: close' header on keep-alive jobs
If the server responds with this header, we _must_ close the connection,
as the server is allowed to ignore the socket and not respond to
anything past that response.
Fixes some RequestServer spins.
Diffstat (limited to 'Userland/Libraries/LibHTTP/HttpJob.cpp')
-rw-r--r-- | Userland/Libraries/LibHTTP/HttpJob.cpp | 12 |
1 files changed, 8 insertions, 4 deletions
diff --git a/Userland/Libraries/LibHTTP/HttpJob.cpp b/Userland/Libraries/LibHTTP/HttpJob.cpp index 58ab0e28d6..6e0115c341 100644 --- a/Userland/Libraries/LibHTTP/HttpJob.cpp +++ b/Userland/Libraries/LibHTTP/HttpJob.cpp @@ -43,13 +43,17 @@ void HttpJob::start(NonnullRefPtr<Core::Socket> socket) }; } -void HttpJob::shutdown() +void HttpJob::shutdown(ShutdownMode mode) { if (!m_socket) return; - m_socket->on_ready_to_read = nullptr; - m_socket->on_connected = nullptr; - m_socket = nullptr; + if (mode == ShutdownMode::CloseSocket) { + m_socket->close(); + } else { + m_socket->on_ready_to_read = nullptr; + m_socket->on_connected = nullptr; + m_socket = nullptr; + } } void HttpJob::register_on_ready_to_read(Function<void()> callback) |