Everywhere: Explicitly specify the size in StringView constructors

This commit moves the length calculations out to be directly on the
StringView users. This is an important step towards the goal of removing
StringView(char const*), as it moves the responsibility of calculating
the size of the string to the user of the StringView (which will prevent
naive uses causing OOB access).

2 files changed, 3 insertions, 2 deletions

diff --git a/Userland/Libraries/LibGfx/Color.cpp b/Userland/Libraries/LibGfx/Color.cpp
index 7d76698d9d..b5abcb8844 100644
--- a/Userland/Libraries/LibGfx/Color.cpp
+++ b/Userland/Libraries/LibGfx/Color.cpp
@@ -80,7 +80,7 @@ Optional<Color> Color::from_string(StringView string)
     struct ColorAndWebName {
         constexpr ColorAndWebName(ARGB32 c, char const* n)
             : color(c)
-            , name(n)
+            , name(n != nullptr ? StringView { n, __builtin_strlen(n) } : StringView {})
         {
         }
         ARGB32 color;
diff --git a/Userland/Libraries/LibGfx/Font/FontStyleMapping.h b/Userland/Libraries/LibGfx/Font/FontStyleMapping.h
index 1653dd0e43..cad4e57c21 100644
--- a/Userland/Libraries/LibGfx/Font/FontStyleMapping.h
+++ b/Userland/Libraries/LibGfx/Font/FontStyleMapping.h
@@ -12,9 +12,10 @@
 namespace Gfx {
 
 struct FontStyleMapping {
+    // NOTE: __builtin_strlen required to make this work at compile time.
     constexpr FontStyleMapping(int s, char const* n)
         : style(s)
-        , name(n)
+        , name(StringView { n, __builtin_strlen(n) })
     {
     }
     int style { 0 };