diff options
| author | sin-ack <sin-ack@users.noreply.github.com> | 2022-07-11 17:32:29 +0000 |
|---|---|---|
| committer | Andreas Kling <kling@serenityos.org> | 2022-07-12 23:11:35 +0200 |
| commit | 3f3f45580ab7266258e97cb3cecf1e24716d61c5 (patch) | |
| tree | 152c7a187c98184d58bf91a326357e0af435edcf /Userland/Libraries/LibGemini | |
| parent | e5f09ea1703bacfbb79a4ad3c587a7d5d3d7bb13 (diff) | |
| download | serenity-3f3f45580ab7266258e97cb3cecf1e24716d61c5.zip | |
Everywhere: Add sv suffix to strings relying on StringView(char const*)
Each of these strings would previously rely on StringView's char const*
constructor overload, which would call __builtin_strlen on the string.
Since we now have operator ""sv, we can replace these with much simpler
versions. This opens the door to being able to remove
StringView(char const*).
No functional changes.
Diffstat (limited to 'Userland/Libraries/LibGemini')
| -rw-r--r-- | Userland/Libraries/LibGemini/Document.cpp | 14 | ||||
| -rw-r--r-- | Userland/Libraries/LibGemini/GeminiRequest.cpp | 2 | ||||
| -rw-r--r-- | Userland/Libraries/LibGemini/Line.cpp | 16 |
3 files changed, 16 insertions, 16 deletions
diff --git a/Userland/Libraries/LibGemini/Document.cpp b/Userland/Libraries/LibGemini/Document.cpp index 623a6b22f7..cea128e7a6 100644 --- a/Userland/Libraries/LibGemini/Document.cpp +++ b/Userland/Libraries/LibGemini/Document.cpp @@ -15,16 +15,16 @@ namespace Gemini { String Document::render_to_html() const { StringBuilder html_builder; - html_builder.append("<!DOCTYPE html>\n<html>\n"); - html_builder.append("<head>\n<title>"); + html_builder.append("<!DOCTYPE html>\n<html>\n"sv); + html_builder.append("<head>\n<title>"sv); html_builder.append(m_url.path()); - html_builder.append("</title>\n</head>\n"); - html_builder.append("<body>\n"); + html_builder.append("</title>\n</head>\n"sv); + html_builder.append("<body>\n"sv); for (auto& line : m_lines) { html_builder.append(line.render_to_html()); } - html_builder.append("</body>"); - html_builder.append("</html>"); + html_builder.append("</body>"sv); + html_builder.append("</html>"sv); return html_builder.build(); } @@ -45,7 +45,7 @@ void Document::read_lines(StringView source) }; for (auto& line : source.lines()) { - if (line.starts_with("```")) { + if (line.starts_with("```"sv)) { close_list_if_needed(); m_inside_preformatted_block = !m_inside_preformatted_block; diff --git a/Userland/Libraries/LibGemini/GeminiRequest.cpp b/Userland/Libraries/LibGemini/GeminiRequest.cpp index eda8439b1d..37c5798ab4 100644 --- a/Userland/Libraries/LibGemini/GeminiRequest.cpp +++ b/Userland/Libraries/LibGemini/GeminiRequest.cpp @@ -14,7 +14,7 @@ ByteBuffer GeminiRequest::to_raw_request() const { StringBuilder builder; builder.append(m_url.to_string()); - builder.append("\r\n"); + builder.append("\r\n"sv); return builder.to_byte_buffer(); } diff --git a/Userland/Libraries/LibGemini/Line.cpp b/Userland/Libraries/LibGemini/Line.cpp index 5e5b2dd810..a4816c5ab9 100644 --- a/Userland/Libraries/LibGemini/Line.cpp +++ b/Userland/Libraries/LibGemini/Line.cpp @@ -13,7 +13,7 @@ String Text::render_to_html() const { StringBuilder builder; builder.append(escape_html_entities(m_text)); - builder.append("<br>\n"); + builder.append("<br>\n"sv); return builder.build(); } @@ -28,9 +28,9 @@ String UnorderedList::render_to_html() const // FIXME: The spec is unclear about what the space means, or where it goes // somehow figure this out StringBuilder builder; - builder.append("<li>"); + builder.append("<li>"sv); builder.append(escape_html_entities(m_text.substring_view(1, m_text.length() - 1))); - builder.append("</li>"); + builder.append("</li>"sv); return builder.build(); } @@ -59,7 +59,7 @@ Link::Link(String text, Document const& document) while (index < m_text.length() && (m_text[index] == ' ' || m_text[index] == '\t')) ++index; auto url_string = m_text.substring_view(index, m_text.length() - index); - auto space_offset = url_string.find_any_of(" \t"); + auto space_offset = url_string.find_any_of(" \t"sv); String url = url_string; if (space_offset.has_value()) { url = url_string.substring_view(0, space_offset.value()); @@ -76,11 +76,11 @@ Link::Link(String text, Document const& document) String Link::render_to_html() const { StringBuilder builder; - builder.append("<a href=\""); + builder.append("<a href=\""sv); builder.append(escape_html_entities(m_url.to_string())); - builder.append("\">"); + builder.append("\">"sv); builder.append(escape_html_entities(m_name)); - builder.append("</a><br>\n"); + builder.append("</a><br>\n"sv); return builder.build(); } @@ -88,7 +88,7 @@ String Preformatted::render_to_html() const { StringBuilder builder; builder.append(escape_html_entities(m_text)); - builder.append("\n"); + builder.append('\n'); return builder.build(); } |