summaryrefslogtreecommitdiff
path: root/Userland/Libraries/LibGUI/Window.h
diff options
context:
space:
mode:
authorBen Wiederhake <BenWiederhake.GitHub@gmx.de>2021-09-07 22:27:18 +0200
committerAndreas Kling <kling@serenityos.org>2021-09-08 10:53:49 +0200
commitc6e56612f560340a1eda66acc6974a2eb447bc46 (patch)
treef38a366b1bf06e5b8bc19f665b52d3997e39fa6c /Userland/Libraries/LibGUI/Window.h
parent0a69da08aa4cbbd21203bcce0f33a322cb94b7ad (diff)
downloadserenity-c6e56612f560340a1eda66acc6974a2eb447bc46.zip
LibGUI+WindowServer: Remove now-obsolete cursor tracking feature
This feature was problematic for several reasons: - Tracking *all* the user activity seems like a privacy nightmare. - LibGUI actually only supports one globally tracking widget per window, even if no window is necessary, or if multiple callbacks are desired. - Widgets can easily get confused whether an event is actually directed at it, or is actually just the result of global tracking. The third item caused an issue where right-clicking CatDog opened two context menus instead of one.
Diffstat (limited to 'Userland/Libraries/LibGUI/Window.h')
-rw-r--r--Userland/Libraries/LibGUI/Window.h5
1 files changed, 0 insertions, 5 deletions
diff --git a/Userland/Libraries/LibGUI/Window.h b/Userland/Libraries/LibGUI/Window.h
index 013bb4fbe3..a6dd2e872a 100644
--- a/Userland/Libraries/LibGUI/Window.h
+++ b/Userland/Libraries/LibGUI/Window.h
@@ -146,10 +146,6 @@ public:
void update();
void update(const Gfx::IntRect&);
- void set_global_cursor_tracking_widget(Widget*);
- Widget* global_cursor_tracking_widget() { return m_global_cursor_tracking_widget.ptr(); }
- const Widget* global_cursor_tracking_widget() const { return m_global_cursor_tracking_widget.ptr(); }
-
void set_automatic_cursor_tracking_widget(Widget*);
Widget* automatic_cursor_tracking_widget() { return m_automatic_cursor_tracking_widget.ptr(); }
const Widget* automatic_cursor_tracking_widget() const { return m_automatic_cursor_tracking_widget.ptr(); }
@@ -253,7 +249,6 @@ private:
float m_alpha_hit_threshold { 0.0f };
RefPtr<Widget> m_main_widget;
WeakPtr<Widget> m_focused_widget;
- WeakPtr<Widget> m_global_cursor_tracking_widget;
WeakPtr<Widget> m_automatic_cursor_tracking_widget;
WeakPtr<Widget> m_hovered_widget;
Gfx::IntRect m_rect_when_windowless;