LibCrypto+LibJS: Better bitwise binary_xor binop

We went through some trouble to make & and | work right. Reimplement ^
in terms of & and | to make ^ work right as well.

This is less fast than a direct implementation, but let's get things
working first.

1 files changed, 1 insertions, 6 deletions

diff --git a/Userland/Libraries/LibCrypto/BigInt/SignedBigInteger.cpp b/Userland/Libraries/LibCrypto/BigInt/SignedBigInteger.cpp
index 3d52592a6e..084f55e8c1 100644
--- a/Userland/Libraries/LibCrypto/BigInt/SignedBigInteger.cpp
+++ b/Userland/Libraries/LibCrypto/BigInt/SignedBigInteger.cpp
@@ -238,12 +238,7 @@ FLATTEN SignedBigInteger SignedBigInteger::bitwise_and(const SignedBigInteger& o
 
 FLATTEN SignedBigInteger SignedBigInteger::bitwise_xor(const SignedBigInteger& other) const
 {
-    auto result = bitwise_xor(other.unsigned_value());
-
-    // The sign bit will have to be XOR'd manually.
-    result.m_sign = is_negative() ^ other.is_negative();
-
-    return result;
+    return bitwise_or(other).minus(bitwise_and(other));
 }
 
 bool SignedBigInteger::operator==(const UnsignedBigInteger& other) const