summaryrefslogtreecommitdiff
path: root/Userland/Libraries/LibCoredump
diff options
context:
space:
mode:
authorAli Mohammad Pur <ali.mpfard@gmail.com>2022-01-27 04:46:27 +0330
committerLinus Groh <mail@linusgroh.de>2022-01-28 22:51:27 +0000
commit6d64b13a1baa8713a28b095ab860699c55fe4e67 (patch)
tree5f8bc67d4a7286128fc27891480973fe8a771c8c /Userland/Libraries/LibCoredump
parentb27b22a68c095daaa2a7f32a4b6cac3659cbb10e (diff)
downloadserenity-6d64b13a1baa8713a28b095ab860699c55fe4e67.zip
LibDebug+Everywhere: Avoid void* -> FlatPtr -> void* dance
And limit the `void*` to the functions that interface the system (i.e. ptrace wrappers). This generally makes the code less riddled with casts.
Diffstat (limited to 'Userland/Libraries/LibCoredump')
-rw-r--r--Userland/Libraries/LibCoredump/Inspector.cpp6
-rw-r--r--Userland/Libraries/LibCoredump/Inspector.h4
2 files changed, 5 insertions, 5 deletions
diff --git a/Userland/Libraries/LibCoredump/Inspector.cpp b/Userland/Libraries/LibCoredump/Inspector.cpp
index 4eb3614332..52dd645882 100644
--- a/Userland/Libraries/LibCoredump/Inspector.cpp
+++ b/Userland/Libraries/LibCoredump/Inspector.cpp
@@ -51,11 +51,11 @@ void Inspector::parse_loaded_libraries(Function<void(float)> on_progress)
});
}
-bool Inspector::poke(void*, FlatPtr) { return false; }
+bool Inspector::poke(FlatPtr, FlatPtr) { return false; }
-Optional<FlatPtr> Inspector::peek(void* address) const
+Optional<FlatPtr> Inspector::peek(FlatPtr address) const
{
- return m_reader->peek_memory((FlatPtr)address);
+ return m_reader->peek_memory(address);
}
PtraceRegisters Inspector::get_registers() const
diff --git a/Userland/Libraries/LibCoredump/Inspector.h b/Userland/Libraries/LibCoredump/Inspector.h
index af92235707..77a21a910b 100644
--- a/Userland/Libraries/LibCoredump/Inspector.h
+++ b/Userland/Libraries/LibCoredump/Inspector.h
@@ -21,8 +21,8 @@ public:
virtual ~Inspector() override = default;
// ^Debug::ProcessInspector
- virtual bool poke(void* address, FlatPtr data) override;
- virtual Optional<FlatPtr> peek(void* address) const override;
+ virtual bool poke(FlatPtr address, FlatPtr data) override;
+ virtual Optional<FlatPtr> peek(FlatPtr address) const override;
virtual PtraceRegisters get_registers() const override;
virtual void set_registers(PtraceRegisters const&) override;
virtual void for_each_loaded_library(Function<IterationDecision(Debug::LoadedLibrary const&)>) const override;