Meta+Userland: Simplify some formatters

These are mostly minor mistakes I've encountered while working on the
removal of StringView(char const*). The usage of builder.put_string over
Format<FormatString>::format is preferrable as it will avoid the
indirection altogether when there's no formatting to be done. Similarly,
there is no need to do format(builder, "{}", number) when
builder.put_u64(number) works equally well.

Additionally a few Strings where only constant strings were used are
replaced with StringViews.

1 files changed, 3 insertions, 2 deletions

diff --git a/Userland/Libraries/LibCore/Directory.h b/Userland/Libraries/LibCore/Directory.h
index 5eebe5f32c..1405477bce 100644
--- a/Userland/Libraries/LibCore/Directory.h
+++ b/Userland/Libraries/LibCore/Directory.h
@@ -62,8 +62,9 @@ struct Formatter<Core::Directory> : Formatter<StringView> {
     {
         auto path = directory.path();
         if (path.is_error())
-            return Formatter<StringView>::format(builder, "<unknown>");
-        return Formatter<StringView>::format(builder, path.release_value().string());
+            TRY(builder.put_string("<unknown>"sv));
+        TRY(builder.put_string(path.release_value().string()));
+        return {};
     }
 };