summaryrefslogtreecommitdiff
path: root/Userland/DevTools
diff options
context:
space:
mode:
authorSam Atkins <atkinssj@serenityos.org>2023-02-19 16:47:18 +0000
committerAndreas Kling <kling@serenityos.org>2023-02-19 18:52:26 +0100
commit307cd4a1daa14b9e24221525fa6ae27de0201e95 (patch)
treeea865eaa3a2e4b33cec7bd6ffc00e9cbd89f7291 /Userland/DevTools
parentbb8c8a67dc87afb51f10dfbe37cddf010d35d097 (diff)
downloadserenity-307cd4a1daa14b9e24221525fa6ae27de0201e95.zip
HackStudio: Make wrapping modes consistent
We were only setting the wrapping mode when triggering the action. So: - Any editors open without triggering a wrapping-mode action would have the default (WrapAtWords) instead of the selected item (NoWrap). - Any editors opened after triggering an action would have the default too. This fixes both situations, by: - Storing the current wrapping mode in `m_wrapping_mode`. Later this could be loaded from the config. - Changing that value any time a wrapping-mode action is triggered. - Setting the wrapping mode on newly-created editors.
Diffstat (limited to 'Userland/DevTools')
-rw-r--r--Userland/DevTools/HackStudio/HackStudioWidget.cpp16
-rw-r--r--Userland/DevTools/HackStudio/HackStudioWidget.h1
2 files changed, 16 insertions, 1 deletions
diff --git a/Userland/DevTools/HackStudio/HackStudioWidget.cpp b/Userland/DevTools/HackStudio/HackStudioWidget.cpp
index 963fad3890..c3283e1c69 100644
--- a/Userland/DevTools/HackStudio/HackStudioWidget.cpp
+++ b/Userland/DevTools/HackStudio/HackStudioWidget.cpp
@@ -788,6 +788,7 @@ void HackStudioWidget::add_new_editor(GUI::TabWidget& parent)
m_all_editor_wrappers.append(wrapper);
wrapper.editor().set_focus(true);
wrapper.editor().set_font(*m_editor_font);
+ wrapper.editor().set_wrapping_mode(m_wrapping_mode);
wrapper.set_project_root(m_project->root_path());
wrapper.editor().on_cursor_change = [this] { on_cursor_change(); };
wrapper.on_change = [this] { update_gml_preview(); };
@@ -1499,14 +1500,17 @@ ErrorOr<void> HackStudioWidget::create_view_menu(GUI::Window& window)
m_wrapping_mode_actions.set_exclusive(true);
auto& wrapping_mode_menu = view_menu.add_submenu("&Wrapping Mode");
m_no_wrapping_action = GUI::Action::create_checkable("&No Wrapping", [&](auto&) {
+ m_wrapping_mode = GUI::TextEditor::WrappingMode::NoWrap;
for (auto& wrapper : m_all_editor_wrappers)
wrapper.editor().set_wrapping_mode(GUI::TextEditor::WrappingMode::NoWrap);
});
m_wrap_anywhere_action = GUI::Action::create_checkable("Wrap &Anywhere", [&](auto&) {
+ m_wrapping_mode = GUI::TextEditor::WrappingMode::WrapAnywhere;
for (auto& wrapper : m_all_editor_wrappers)
wrapper.editor().set_wrapping_mode(GUI::TextEditor::WrappingMode::WrapAnywhere);
});
m_wrap_at_words_action = GUI::Action::create_checkable("Wrap at &Words", [&](auto&) {
+ m_wrapping_mode = GUI::TextEditor::WrappingMode::WrapAtWords;
for (auto& wrapper : m_all_editor_wrappers)
wrapper.editor().set_wrapping_mode(GUI::TextEditor::WrappingMode::WrapAtWords);
});
@@ -1519,7 +1523,17 @@ ErrorOr<void> HackStudioWidget::create_view_menu(GUI::Window& window)
wrapping_mode_menu.add_action(*m_wrap_anywhere_action);
wrapping_mode_menu.add_action(*m_wrap_at_words_action);
- m_no_wrapping_action->set_checked(true);
+ switch (m_wrapping_mode) {
+ case GUI::TextEditor::NoWrap:
+ m_no_wrapping_action->set_checked(true);
+ break;
+ case GUI::TextEditor::WrapAtWords:
+ m_wrap_at_words_action->set_checked(true);
+ break;
+ case GUI::TextEditor::WrapAnywhere:
+ m_wrap_anywhere_action->set_checked(true);
+ break;
+ }
auto icon = TRY(Gfx::Bitmap::load_from_file("/res/icons/16x16/app-font-editor.png"sv));
m_editor_font_action = GUI::Action::create("Editor &Font...", icon,
diff --git a/Userland/DevTools/HackStudio/HackStudioWidget.h b/Userland/DevTools/HackStudio/HackStudioWidget.h
index 63e2e20595..e1325628cc 100644
--- a/Userland/DevTools/HackStudio/HackStudioWidget.h
+++ b/Userland/DevTools/HackStudio/HackStudioWidget.h
@@ -253,6 +253,7 @@ private:
RefPtr<Gfx::Font> m_editor_font;
RefPtr<GUI::Action> m_editor_font_action;
+ GUI::TextEditor::WrappingMode m_wrapping_mode { GUI::TextEditor::NoWrap };
GUI::ActionGroup m_wrapping_mode_actions;
RefPtr<GUI::Action> m_no_wrapping_action;
RefPtr<GUI::Action> m_wrap_anywhere_action;