UserspaceEmulator: Correctly fail in execve when binary is inaccessible

Previously, Emulator::virt$execve would not report ENOENT and EACCES
when the binary to be executed was nonexistent or not executable. This
broke the execp family of functions, which rely on ENOENT being reported
in order to know that they should continue searching $PATH.

1 files changed, 5 insertions, 0 deletions

diff --git a/Userland/DevTools/UserspaceEmulator/Emulator_syscalls.cpp b/Userland/DevTools/UserspaceEmulator/Emulator_syscalls.cpp
index 6b43e9ce45..2cc363927b 100644
--- a/Userland/DevTools/UserspaceEmulator/Emulator_syscalls.cpp
+++ b/Userland/DevTools/UserspaceEmulator/Emulator_syscalls.cpp
@@ -1225,6 +1225,11 @@ int Emulator::virt$execve(FlatPtr params_addr)
     for (auto& argument : arguments)
         reportln("=={}==    - {}", getpid(), argument);
 
+    if (access(path.characters(), X_OK) < 0) {
+        if (errno == ENOENT || errno == EACCES)
+            return -errno;
+    }
+
     Vector<char*> argv;
     Vector<char*> envp;