diff options
author | Gunnar Beutner <gbeutner@serenityos.org> | 2021-05-18 10:17:47 +0200 |
---|---|---|
committer | Andreas Kling <kling@serenityos.org> | 2021-05-19 22:51:42 +0200 |
commit | 6ac1ca5a9afbc900a483a1c528eb4b1c62a1c67e (patch) | |
tree | 1d99d262c5fd417538955762a35386ef0112594f /Userland/DevTools/Profiler/TimelineTrack.cpp | |
parent | 7dc77bd833ea245dba8d1857f66ee05493192cad (diff) | |
download | serenity-6ac1ca5a9afbc900a483a1c528eb4b1c62a1c67e.zip |
Profiler: Remove ability to filter Kernel::Scheduler::yield() frames
Hiding those frames doesn't really make sense. They're a major
contributor to a process' spent CPU time and show up in a lot of
profiles. That however is because those processes really do spend
quite a bit of time in the scheduler by doing lots of context
switches, like WindowServer when responding to IPC calls.
Instead of hiding these for aesthetic reasons we should instead
improve the scheduler.
Diffstat (limited to 'Userland/DevTools/Profiler/TimelineTrack.cpp')
-rw-r--r-- | Userland/DevTools/Profiler/TimelineTrack.cpp | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/Userland/DevTools/Profiler/TimelineTrack.cpp b/Userland/DevTools/Profiler/TimelineTrack.cpp index 6f430bed36..e04934e0d4 100644 --- a/Userland/DevTools/Profiler/TimelineTrack.cpp +++ b/Userland/DevTools/Profiler/TimelineTrack.cpp @@ -71,12 +71,6 @@ void TimelineTrack::paint_event(GUI::PaintEvent& event) if (!m_process.valid_at(event.timestamp)) continue; - if (!m_profile.show_scheduler() && !event.frames.is_empty()) { - const auto& top_frame = event.frames[event.frames.size() - 1]; - if (top_frame.symbol == "Kernel::Scheduler::yield()"sv) - continue; - } - auto& histogram = event.in_kernel ? kernel_histogram : usermode_histogram; histogram.insert(clamp_timestamp(event.timestamp), 1 + event.lost_samples); } |