diff options
author | Ali Chraghi <chraghiali1@gmail.com> | 2022-04-08 00:36:58 +0430 |
---|---|---|
committer | Linus Groh <mail@linusgroh.de> | 2022-04-12 21:43:07 +0100 |
commit | 8f5d80a41d2aa4ad976344e1e07205511a72fa56 (patch) | |
tree | c8e7753aa4d7801a38592153800aeaeb1545027e /Userland/Applications | |
parent | 34a0f8cdc77d4645296382af37eb8ea1e48993cf (diff) | |
download | serenity-8f5d80a41d2aa4ad976344e1e07205511a72fa56.zip |
CrashReporter: Implement `Save Backtrace` button
Diffstat (limited to 'Userland/Applications')
-rw-r--r-- | Userland/Applications/CrashReporter/CMakeLists.txt | 2 | ||||
-rw-r--r-- | Userland/Applications/CrashReporter/CrashReporterWindow.gml | 5 | ||||
-rw-r--r-- | Userland/Applications/CrashReporter/main.cpp | 24 |
3 files changed, 30 insertions, 1 deletions
diff --git a/Userland/Applications/CrashReporter/CMakeLists.txt b/Userland/Applications/CrashReporter/CMakeLists.txt index 49c381852c..ead6e9c962 100644 --- a/Userland/Applications/CrashReporter/CMakeLists.txt +++ b/Userland/Applications/CrashReporter/CMakeLists.txt @@ -13,4 +13,4 @@ set(SOURCES ) serenity_app(CrashReporter ICON app-crash-reporter) -target_link_libraries(CrashReporter LibCore LibCoredump LibDesktop LibGUI LibMain) +target_link_libraries(CrashReporter LibCore LibCoredump LibDesktop LibFileSystemAccessClient LibGUI LibMain) diff --git a/Userland/Applications/CrashReporter/CrashReporterWindow.gml b/Userland/Applications/CrashReporter/CrashReporterWindow.gml index e5597b145e..90e2cd1bcc 100644 --- a/Userland/Applications/CrashReporter/CrashReporterWindow.gml +++ b/Userland/Applications/CrashReporter/CrashReporterWindow.gml @@ -88,6 +88,11 @@ fixed_width: 150 } + @GUI::Button { + name: "save_backtrace_button" + text: "Save Backtrace" + } + // HACK: We need something like Layout::add_spacer() in GML! :^) @GUI::Widget {} diff --git a/Userland/Applications/CrashReporter/main.cpp b/Userland/Applications/CrashReporter/main.cpp index 61e0842432..6fcc1f86b5 100644 --- a/Userland/Applications/CrashReporter/main.cpp +++ b/Userland/Applications/CrashReporter/main.cpp @@ -1,6 +1,7 @@ /* * Copyright (c) 2020-2021, Linus Groh <linusg@serenityos.org> * Copyright (c) 2021, Andreas Kling <kling@serenityos.org> + * Copyright (c) 2022, Ali Chraghi <chraghiali1@gmail.com> * * SPDX-License-Identifier: BSD-2-Clause */ @@ -20,6 +21,7 @@ #include <LibDesktop/AppFile.h> #include <LibDesktop/Launcher.h> #include <LibELF/Core.h> +#include <LibFileSystemAccessClient/Client.h> #include <LibGUI/Application.h> #include <LibGUI/BoxLayout.h> #include <LibGUI/Button.h> @@ -28,6 +30,7 @@ #include <LibGUI/ImageWidget.h> #include <LibGUI/Label.h> #include <LibGUI/LinkLabel.h> +#include <LibGUI/MessageBox.h> #include <LibGUI/Progressbar.h> #include <LibGUI/TabWidget.h> #include <LibGUI/TextEditor.h> @@ -138,6 +141,7 @@ ErrorOr<int> serenity_main(Main::Arguments arguments) char const* coredump_path = nullptr; bool unlink_on_exit = false; + StringBuilder full_backtrace; Core::ArgsParser args_parser; args_parser.set_general_help("Show information from an application crash coredump."); @@ -270,6 +274,25 @@ ErrorOr<int> serenity_main(Main::Arguments arguments) } }; + auto& save_backtrace_button = *widget->find_descendant_of_type_named<GUI::Button>("save_backtrace_button"); + save_backtrace_button.set_icon(TRY(Gfx::Bitmap::try_load_from_file("/res/icons/16x16/save.png"))); + save_backtrace_button.on_click = [&](auto) { + if (full_backtrace.is_empty()) { + GUI::MessageBox::show(window, "Backtrace has not been generated yet. Please wait...", "Empty Backtrace", GUI::MessageBox::Type::Error); + return; + } + + LexicalPath lexical_path(String::formatted("{}_{}_backtrace.txt", pid, app_name)); + auto file_or_error = FileSystemAccessClient::Client::the().try_save_file(window, lexical_path.title(), lexical_path.extension()); + if (file_or_error.is_error()) { + GUI::MessageBox::show(window, String::formatted("Couldn't save file: {}.", file_or_error.error()), "Saving backtrace failed", GUI::MessageBox::Type::Error); + return; + } + + auto file = file_or_error.value(); + file->write(full_backtrace.to_string()); + }; + (void)Threading::BackgroundAction<ThreadBacktracesAndCpuRegisters>::construct( [&, coredump = move(coredump)](auto&) { ThreadBacktracesAndCpuRegisters results; @@ -301,6 +324,7 @@ ErrorOr<int> serenity_main(Main::Arguments arguments) backtrace_text_editor->set_text(backtrace.text); backtrace_text_editor->set_mode(GUI::TextEditor::Mode::ReadOnly); backtrace_text_editor->set_should_hide_unnecessary_scrollbars(true); + full_backtrace.appendff("==== {} ====\n{}\n", backtrace.title, backtrace.text); } for (auto& cpu_registers : results.thread_cpu_registers) { |