LibC: Remove 'int* aslave' parameter from forkpty()

Only keep track of that (and eventually close() it) internally instead.
This argument is not present on other systems, so we were running into
compatibility issues with ports.
Also bring the implementation closer to Linux and OpenBSD by making sure
to close the slave pty fd in the fork()'d child as well as _exit()'ing
on login_tty() failure - it's non-POSIX, so those are our references
here. :^)

1 files changed, 2 insertions, 4 deletions

diff --git a/Userland/Applications/Terminal/main.cpp b/Userland/Applications/Terminal/main.cpp
index 0292207769..191a0ada89 100644
--- a/Userland/Applications/Terminal/main.cpp
+++ b/Userland/Applications/Terminal/main.cpp
@@ -261,8 +261,8 @@ int main(int argc, char** argv)
     RefPtr<Core::ConfigFile> config = Core::ConfigFile::get_for_app("Terminal");
     Core::File::ensure_parent_directories(config->filename());
 
-    int ptm_fd, pts_fd;
-    pid_t shell_pid = forkpty(&ptm_fd, &pts_fd, nullptr, nullptr, nullptr);
+    int ptm_fd;
+    pid_t shell_pid = forkpty(&ptm_fd, nullptr, nullptr, nullptr);
     if (shell_pid < 0) {
         perror("forkpty");
         return 1;
@@ -276,8 +276,6 @@ int main(int argc, char** argv)
         VERIFY_NOT_REACHED();
     }
 
-    close(pts_fd);
-
     auto* pts_name = ptsname(ptm_fd);
     utmp_update(pts_name, shell_pid, true);