diff options
author | sin-ack <sin-ack@users.noreply.github.com> | 2022-07-11 19:53:29 +0000 |
---|---|---|
committer | Andreas Kling <kling@serenityos.org> | 2022-07-12 23:11:35 +0200 |
commit | c70f45ff4498fcb7ce0671e9107ecff8009d7eb2 (patch) | |
tree | 6250cc4ba6c43ed57639f3d7ff9c5fd34800989f /Userland/Applications/Spreadsheet | |
parent | e3da0adfe6d278424970dad5a642bda650737e42 (diff) | |
download | serenity-c70f45ff4498fcb7ce0671e9107ecff8009d7eb2.zip |
Everywhere: Explicitly specify the size in StringView constructors
This commit moves the length calculations out to be directly on the
StringView users. This is an important step towards the goal of removing
StringView(char const*), as it moves the responsibility of calculating
the size of the string to the user of the StringView (which will prevent
naive uses causing OOB access).
Diffstat (limited to 'Userland/Applications/Spreadsheet')
-rw-r--r-- | Userland/Applications/Spreadsheet/ExportDialog.cpp | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/Userland/Applications/Spreadsheet/ExportDialog.cpp b/Userland/Applications/Spreadsheet/ExportDialog.cpp index 37c8f2e72d..502e9be0b2 100644 --- a/Userland/Applications/Spreadsheet/ExportDialog.cpp +++ b/Userland/Applications/Spreadsheet/ExportDialog.cpp @@ -280,9 +280,11 @@ Result<void, String> ExportDialog::make_and_run_for(StringView mime, Core::File& bool result = file.write(file_content); if (!result) { int error_number = errno; + auto const* error = strerror(error_number); + StringBuilder sb; sb.append("Unable to save file. Error: "); - sb.append(strerror(error_number)); + sb.append({ error, strlen(error) }); return sb.to_string(); } |