diff options
| author | Daniel Bertalan <dani@danielbertalan.dev> | 2022-10-21 15:53:20 +0200 |
|---|---|---|
| committer | Andrew Kaster <andrewdkaster@gmail.com> | 2022-11-06 10:25:08 -0700 |
| commit | 4296425bd8f2212e70167118e5a76c4922565080 (patch) | |
| tree | 5574318cc583989f1a3b3b96043a23b101d24b91 /Userland/Applications/Spreadsheet/Position.h | |
| parent | 4e406b07305007c84cef637f5753c196c34fac9c (diff) | |
| download | serenity-4296425bd8f2212e70167118e5a76c4922565080.zip | |
Everywhere: Remove redundant inequality comparison operators
C++20 can automatically synthesize `operator!=` from `operator==`, so
there is no point in writing such functions by hand if all they do is
call through to `operator==`.
This fixes a compile error with compilers that implement P2468 (Clang
16 currently). This paper restores the C++17 behavior that if both
`T::operator==(U)` and `T::operator!=(U)` exist, `U == T` won't be
rewritten in reverse to call `T::operator==(U)`. Removing `!=` operators
makes the rewriting possible again.
See https://reviews.llvm.org/D134529#3853062
Diffstat (limited to 'Userland/Applications/Spreadsheet/Position.h')
| -rw-r--r-- | Userland/Applications/Spreadsheet/Position.h | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/Userland/Applications/Spreadsheet/Position.h b/Userland/Applications/Spreadsheet/Position.h index a1f43ccd1c..7bd73a0b70 100644 --- a/Userland/Applications/Spreadsheet/Position.h +++ b/Userland/Applications/Spreadsheet/Position.h @@ -37,11 +37,6 @@ struct Position { return row == other.row && column == other.column; } - bool operator!=(Position const& other) const - { - return !(other == *this); - } - String to_cell_identifier(Sheet const& sheet) const; URL to_url(Sheet const& sheet) const; |