diff options
| author | Ali Mohammad Pur <ali.mpfard@gmail.com> | 2021-11-21 05:08:00 +0330 |
|---|---|---|
| committer | Ali Mohammad Pur <Ali.mpfard@gmail.com> | 2021-12-12 14:49:49 +0330 |
| commit | 5f1a34bba3a0eb81b8d4474daffe8e837828277e (patch) | |
| tree | 503710d8cee210aca8394875321957f2a8312299 /Userland/Applications/Spreadsheet/Cell.h | |
| parent | 235eb0b1adba5920ce914e5a908b5940c2ddf9f8 (diff) | |
| download | serenity-5f1a34bba3a0eb81b8d4474daffe8e837828277e.zip | |
Spreadsheet: Avoid using Value.to_string_without_side_effects()
We should use .to_string() and handle the possible exceptions.
This makes the displayed cell contents so much more informative than
'[object Object]' :^)
Diffstat (limited to 'Userland/Applications/Spreadsheet/Cell.h')
| -rw-r--r-- | Userland/Applications/Spreadsheet/Cell.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/Userland/Applications/Spreadsheet/Cell.h b/Userland/Applications/Spreadsheet/Cell.h index d2d3541c1a..1e8830084e 100644 --- a/Userland/Applications/Spreadsheet/Cell.h +++ b/Userland/Applications/Spreadsheet/Cell.h @@ -79,8 +79,8 @@ struct Cell : public Weakable<Cell> { m_conditional_formats = move(fmts); } - String typed_display() const; - JS::Value typed_js_data() const; + JS::ThrowCompletionOr<String> typed_display() const; + JS::ThrowCompletionOr<JS::Value> typed_js_data() const; const CellType& type() const; const CellTypeMetadata& type_metadata() const { return m_type_metadata; } |