summaryrefslogtreecommitdiff
path: root/Userland/Applications/PixelPaint/LayerPropertiesWidget.h
diff options
context:
space:
mode:
authorMustafa Quraish <mustafaq9@gmail.com>2021-09-04 19:16:33 -0400
committerAndreas Kling <kling@serenityos.org>2021-09-09 11:27:48 +0200
commit3bf204fd0302e37481046f957c069fb2c4d40692 (patch)
tree73da7a4b987ceed3d1bad223b453f79d0fc04127 /Userland/Applications/PixelPaint/LayerPropertiesWidget.h
parent522f0841fd362c67505d16d0db2b972e21c9b386 (diff)
downloadserenity-3bf204fd0302e37481046f957c069fb2c4d40692.zip
PixelPaint: Fix BucketTool out of memory crashes
The BFS implementation for BucketTool's flood-fill had sitations which could result in infinite loop, causing OOM crashes due to the queue growing unbounded. The way to fix this is to keep track of the pixels we have already visited in the flood-fill algorithm and ignore those if we ever encounter them again. This also fixes the crashing issue from #9003. We still need a better way to account for transparency, but that is beyond the scope of this commit, and this issue still exists without any transparent pixels.
Diffstat (limited to 'Userland/Applications/PixelPaint/LayerPropertiesWidget.h')
0 files changed, 0 insertions, 0 deletions