AK: Add support for removing SinglyLinkedList nodes during iteration

This commit also fixes the now-broken usage of SinglyLinkedList::remove
in the Piano application.

1 files changed, 11 insertions, 0 deletions

diff --git a/Tests/AK/TestSinglyLinkedList.cpp b/Tests/AK/TestSinglyLinkedList.cpp
index 3df43d2cb5..750940f74e 100644
--- a/Tests/AK/TestSinglyLinkedList.cpp
+++ b/Tests/AK/TestSinglyLinkedList.cpp
@@ -59,3 +59,14 @@ TEST_CASE(should_find_const_with_predicate)
 
     EXPECT_EQ(sut.end(), sut.find_if([](const auto v) { return v == 42; }));
 }
+
+TEST_CASE(removal_during_iteration)
+{
+    auto list = make_list();
+    auto size = list.size_slow();
+
+    for (auto it = list.begin(); it != list.end(); ++it, --size) {
+        VERIFY(list.size_slow() == size);
+        it.remove(list);
+    }
+}