summaryrefslogtreecommitdiff
path: root/Tests
diff options
context:
space:
mode:
authorAndreas Kling <kling@serenityos.org>2022-12-19 19:32:31 +0100
committerAndreas Kling <kling@serenityos.org>2023-01-01 10:09:02 +0100
commit16f934474f8b10fcd26cd707b643aaa03dddd8f8 (patch)
tree849f950b13b1b4baf2f85d3c482eda1f17192794 /Tests
parent47b9e8e6516d3608aca93426da6c42819c64d8e2 (diff)
downloadserenity-16f934474f8b10fcd26cd707b643aaa03dddd8f8.zip
Kernel+Tests: Allow deleting someone else's file in my sticky directory
This should be allowed according to Dr. POSIX. :^)
Diffstat (limited to 'Tests')
-rw-r--r--Tests/LibC/TestIo.cpp44
1 files changed, 44 insertions, 0 deletions
diff --git a/Tests/LibC/TestIo.cpp b/Tests/LibC/TestIo.cpp
index 5b1bb1b6db..e121876d73 100644
--- a/Tests/LibC/TestIo.cpp
+++ b/Tests/LibC/TestIo.cpp
@@ -15,6 +15,7 @@
#include <sys/mman.h>
#include <sys/stat.h>
#include <sys/uio.h>
+#include <sys/wait.h>
#include <unistd.h>
#define EXPECT_ERROR_2(err, syscall, arg1, arg2) \
@@ -356,6 +357,49 @@ TEST_CASE(rmdir_dot_dot)
EXPECT_EQ(rc, 0);
}
+TEST_CASE(rmdir_someone_elses_directory_in_my_sticky_directory)
+{
+ // NOTE: This test only works when run as root, since it has to chown a directory to someone else.
+ if (getuid() != 0)
+ return;
+
+ // Create /tmp/sticky-dir a sticky directory owned by 12345:12345
+ // Then, create /tmp/sticky-dir/notmine, a normal directory owned by 23456:23456
+ // Then, fork and seteuid to 12345, and try to rmdir the "notmine" directory. This should succeed.
+ // In the parent, waitpid on the child, and finally rmdir /tmp/sticky-dir
+
+ int rc = mkdir("/tmp/sticky-dir", 01777);
+ EXPECT_EQ(rc, 0);
+
+ rc = chown("/tmp/sticky-dir", 12345, 12345);
+ EXPECT_EQ(rc, 0);
+
+ rc = mkdir("/tmp/sticky-dir/notmine", 0700);
+ EXPECT_EQ(rc, 0);
+
+ rc = chown("/tmp/sticky-dir/notmine", 23456, 23456);
+ EXPECT_EQ(rc, 0);
+
+ int pid = fork();
+ EXPECT(pid >= 0);
+
+ if (pid == 0) {
+ // We are in the child.
+ rc = seteuid(12345);
+ EXPECT_EQ(rc, 0);
+
+ rc = rmdir("/tmp/sticky-dir/notmine");
+ EXPECT_EQ(rc, 0);
+ _exit(0);
+ }
+
+ int status = 0;
+ waitpid(pid, &status, 0);
+
+ rc = rmdir("/tmp/sticky-dir");
+ EXPECT_EQ(rc, 0);
+}
+
TEST_CASE(rmdir_while_inside_dir)
{
int rc = mkdir("/home/anon/testdir", 0700);