summaryrefslogtreecommitdiff
path: root/Tests
diff options
context:
space:
mode:
authorLinus Groh <mail@linusgroh.de>2023-04-13 00:47:15 +0200
committerLinus Groh <mail@linusgroh.de>2023-04-13 14:29:42 +0200
commitb84f8fb55b2f926970af1d657314bb82a905ae1d (patch)
treebef32f893a3077f71b29e955fbf036602e6e83e5 /Tests
parented9e2366da6a28ad39bf6f71d70201d59fa79220 (diff)
downloadserenity-b84f8fb55b2f926970af1d657314bb82a905ae1d.zip
LibJS: Make intrinsics getters return NonnullGCPtr
Some of these are allocated upon initialization of the intrinsics, and some lazily, but in neither case the getters actually return a nullptr. This saves us a whole bunch of pointer dereferences (as NonnullGCPtr has an `operator T&()`), and also has the interesting side effect of forcing us to explicitly use the FunctionObject& overload of call(), as passing a NonnullGCPtr is ambigous - it could implicitly be turned into a Value _or_ a FunctionObject& (so we have to dereference manually).
Diffstat (limited to 'Tests')
-rw-r--r--Tests/LibWasm/test-wasm.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/Tests/LibWasm/test-wasm.cpp b/Tests/LibWasm/test-wasm.cpp
index 68067b9aed..dd8f2b9299 100644
--- a/Tests/LibWasm/test-wasm.cpp
+++ b/Tests/LibWasm/test-wasm.cpp
@@ -56,7 +56,7 @@ public:
static JS::ThrowCompletionOr<WebAssemblyModule*> create(JS::Realm& realm, Wasm::Module module, HashMap<Wasm::Linker::Name, Wasm::ExternValue> const& imports)
{
auto& vm = realm.vm();
- auto instance = MUST_OR_THROW_OOM(realm.heap().allocate<WebAssemblyModule>(realm, *realm.intrinsics().object_prototype()));
+ auto instance = MUST_OR_THROW_OOM(realm.heap().allocate<WebAssemblyModule>(realm, realm.intrinsics().object_prototype()));
instance->m_module = move(module);
Wasm::Linker linker(*instance->m_module);
linker.link(imports);