Everywhere: Rename to_{string => deprecated_string}() where applicable

This will make it easier to support both string types at the same time
while we convert code, and tracking down remaining uses.

One big exception is Value::to_string() in LibJS, where the name is
dictated by the ToString AO.

2 files changed, 7 insertions, 7 deletions

diff --git a/Tests/LibRegex/Regex.cpp b/Tests/LibRegex/Regex.cpp
index 8abf62dd7f..7c48e74a0c 100644
--- a/Tests/LibRegex/Regex.cpp
+++ b/Tests/LibRegex/Regex.cpp
@@ -377,7 +377,7 @@ TEST_CASE(ini_file_entries)
 
     if constexpr (REGEX_DEBUG) {
         for (auto& v : result.matches)
-            fprintf(stderr, "%s\n", v.view.to_string().characters());
+            fprintf(stderr, "%s\n", v.view.to_deprecated_string().characters());
     }
 
     EXPECT_EQ(result.matches.at(0).view, "[Window]");
@@ -1084,7 +1084,7 @@ TEST_CASE(single_match_flag)
         auto result = re.match("ABC"sv);
         EXPECT_EQ(result.success, true);
         EXPECT_EQ(result.matches.size(), 1u);
-        EXPECT_EQ(result.matches.first().view.to_string(), "A"sv);
+        EXPECT_EQ(result.matches.first().view.to_deprecated_string(), "A"sv);
     }
 }
 
@@ -1097,7 +1097,7 @@ TEST_CASE(inversion_state_in_char_class)
         auto result = re.match("hello"sv);
         EXPECT_EQ(result.success, true);
         EXPECT_EQ(result.matches.size(), 1u);
-        EXPECT_EQ(result.matches.first().view.to_string(), "h"sv);
+        EXPECT_EQ(result.matches.first().view.to_deprecated_string(), "h"sv);
     }
     {
         Regex<ECMA262> re("^(?:([^\\s!\"#%-,\\./;->@\\[-\\^`\\{-~]+(?=([=~}\\s/.)|]))))"sv, ECMAScriptFlags::Global);
@@ -1105,8 +1105,8 @@ TEST_CASE(inversion_state_in_char_class)
         auto result = re.match("slideNumbers}}"sv);
         EXPECT_EQ(result.success, true);
         EXPECT_EQ(result.matches.size(), 1u);
-        EXPECT_EQ(result.matches.first().view.to_string(), "slideNumbers"sv);
-        EXPECT_EQ(result.capture_group_matches.first()[0].view.to_string(), "slideNumbers"sv);
-        EXPECT_EQ(result.capture_group_matches.first()[1].view.to_string(), "}"sv);
+        EXPECT_EQ(result.matches.first().view.to_deprecated_string(), "slideNumbers"sv);
+        EXPECT_EQ(result.capture_group_matches.first()[0].view.to_deprecated_string(), "slideNumbers"sv);
+        EXPECT_EQ(result.capture_group_matches.first()[1].view.to_deprecated_string(), "}"sv);
     }
 }
diff --git a/Tests/LibRegex/RegexLibC.cpp b/Tests/LibRegex/RegexLibC.cpp
index 3e68b96e7a..1ff52499ef 100644
--- a/Tests/LibRegex/RegexLibC.cpp
+++ b/Tests/LibRegex/RegexLibC.cpp
@@ -204,7 +204,7 @@ TEST_CASE(character_class2)
         fprintf(stderr, "Matches[%i].rm_so: %li, .rm_eo: %li .rm_cnt: %li: ", i, matches[i].rm_so, matches[i].rm_eo, matches[i].rm_cnt);
         fprintf(stderr, "haystack length: %lu\n", haystack.length());
         if (matches[i].rm_so != -1)
-            fprintf(stderr, "%s\n", haystack.substring_view(matches[i].rm_so, matches[i].rm_eo - matches[i].rm_so).to_string().characters());
+            fprintf(stderr, "%s\n", haystack.substring_view(matches[i].rm_so, matches[i].rm_eo - matches[i].rm_so).to_deprecated_string().characters());
     }
 #endif