AK: Make Variant::visit() prefer overloads accepting T const& over T&

This makes the following code behave as expected:

    Variant<int, String> x { some_string() };
    x.visit(
        [](String const&) {}, // Expectation is for this to be called
        [](auto&) {});

1 files changed, 14 insertions, 0 deletions

diff --git a/Tests/AK/TestVariant.cpp b/Tests/AK/TestVariant.cpp
index af87669671..f55d176537 100644
--- a/Tests/AK/TestVariant.cpp
+++ b/Tests/AK/TestVariant.cpp
@@ -48,6 +48,20 @@ TEST_CASE(visit_const)
         [&](auto const&) {});
 
     EXPECT(correct);
+
+    correct = false;
+    auto the_value_but_not_const = the_value;
+    the_value_but_not_const.visit(
+        [&](String const&) { correct = true; },
+        [&](auto&) {});
+
+    EXPECT(correct);
+
+    correct = false;
+    the_value_but_not_const.visit(
+        [&]<typename T>(T&) { correct = !IsConst<T>; });
+
+    EXPECT(correct);
 }
 
 TEST_CASE(destructor)