diff options
| author | sin-ack <sin-ack@users.noreply.github.com> | 2022-07-11 17:32:29 +0000 |
|---|---|---|
| committer | Andreas Kling <kling@serenityos.org> | 2022-07-12 23:11:35 +0200 |
| commit | 3f3f45580ab7266258e97cb3cecf1e24716d61c5 (patch) | |
| tree | 152c7a187c98184d58bf91a326357e0af435edcf /Tests/AK/TestIPv4Address.cpp | |
| parent | e5f09ea1703bacfbb79a4ad3c587a7d5d3d7bb13 (diff) | |
| download | serenity-3f3f45580ab7266258e97cb3cecf1e24716d61c5.zip | |
Everywhere: Add sv suffix to strings relying on StringView(char const*)
Each of these strings would previously rely on StringView's char const*
constructor overload, which would call __builtin_strlen on the string.
Since we now have operator ""sv, we can replace these with much simpler
versions. This opens the door to being able to remove
StringView(char const*).
No functional changes.
Diffstat (limited to 'Tests/AK/TestIPv4Address.cpp')
| -rw-r--r-- | Tests/AK/TestIPv4Address.cpp | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/Tests/AK/TestIPv4Address.cpp b/Tests/AK/TestIPv4Address.cpp index 094b1a7253..48c27ee811 100644 --- a/Tests/AK/TestIPv4Address.cpp +++ b/Tests/AK/TestIPv4Address.cpp @@ -66,7 +66,7 @@ TEST_CASE(should_convert_to_string) TEST_CASE(should_make_ipv4_address_from_string) { - auto const addr = IPv4Address::from_string("192.168.0.1"); + auto const addr = IPv4Address::from_string("192.168.0.1"sv); EXPECT(addr.has_value()); EXPECT_EQ(192, addr.value()[0]); @@ -77,21 +77,21 @@ TEST_CASE(should_make_ipv4_address_from_string) TEST_CASE(should_make_empty_optional_from_bad_string) { - auto const addr = IPv4Address::from_string("bad string"); + auto const addr = IPv4Address::from_string("bad string"sv); EXPECT(!addr.has_value()); } TEST_CASE(should_make_empty_optional_from_out_of_range_values) { - auto const addr = IPv4Address::from_string("192.168.0.500"); + auto const addr = IPv4Address::from_string("192.168.0.500"sv); EXPECT(!addr.has_value()); } TEST_CASE(should_fill_d_octet_from_1_part) { - auto const addr = IPv4Address::from_string("1"); + auto const addr = IPv4Address::from_string("1"sv); EXPECT(addr.has_value()); EXPECT_EQ(0, addr.value()[0]); @@ -102,7 +102,7 @@ TEST_CASE(should_fill_d_octet_from_1_part) TEST_CASE(should_fill_a_and_d_octets_from_2_parts) { - auto const addr = IPv4Address::from_string("192.1"); + auto const addr = IPv4Address::from_string("192.1"sv); EXPECT(addr.has_value()); EXPECT_EQ(192, addr.value()[0]); @@ -113,7 +113,7 @@ TEST_CASE(should_fill_a_and_d_octets_from_2_parts) TEST_CASE(should_fill_a_b_d_octets_from_3_parts) { - auto const addr = IPv4Address::from_string("192.168.1"); + auto const addr = IPv4Address::from_string("192.168.1"sv); EXPECT(addr.has_value()); EXPECT_EQ(192, addr.value()[0]); |