LibCore: Make Core::File::open() return a Result<NNRP<File>, String>

It was impractical to return a RefPtr<File> since that left us no way
to extract the error string. This is usually needed for the UI, so the
old static open() got basically no use.

1 files changed, 5 insertions, 4 deletions

diff --git a/Shell/main.cpp b/Shell/main.cpp
index 612a013a4a..cba616c0ca 100644
--- a/Shell/main.cpp
+++ b/Shell/main.cpp
@@ -993,12 +993,13 @@ void load_history()
 
 void save_history()
 {
-    auto history_file = Core::File::open(get_history_path(), Core::IODevice::WriteOnly, 0600);
-    if (!history_file)
+    auto file_or_error = Core::File::open(get_history_path(), Core::IODevice::WriteOnly, 0600);
+    if (file_or_error.is_error())
         return;
+    auto& file = *file_or_error.value();
     for (const auto& line : editor.history()) {
-        history_file->write(line);
-        history_file->write("\n");
+        file.write(line);
+        file.write("\n");
     }
 }