diff options
author | Robin Burchell <robin+git@viroteck.net> | 2019-07-19 17:46:21 +0200 |
---|---|---|
committer | Andreas Kling <awesomekling@gmail.com> | 2019-07-19 19:06:28 +0200 |
commit | 2d4d465206d0ca2bc6f1cc70edba89b848768f98 (patch) | |
tree | 2fbb25ab6087aa272dc03cd1bd0df84529364ef1 /Shell/LineEditor.h | |
parent | f8beb0f665af7d21bfe36f48647b8cd88f331c52 (diff) | |
download | serenity-2d4d465206d0ca2bc6f1cc70edba89b848768f98.zip |
SharedBuffer: Fix a denial of service
It's a very bad idea to increment the refcount on behalf of another
process. That process may (for either benign or evil reasons) not
reference the SharedBuffer, and then we'll be stuck with loads of
SharedBuffers until we OOM.
Instead, increment the refcount when the buffer is mapped. That way, a
buffer is only kept if *someone* has explicitly requested it via
get_shared_buffer.
Fixes #341
Diffstat (limited to 'Shell/LineEditor.h')
0 files changed, 0 insertions, 0 deletions