diff options
author | Liav A <liavalb@gmail.com> | 2023-04-11 03:50:15 +0300 |
---|---|---|
committer | Linus Groh <mail@linusgroh.de> | 2023-04-14 19:27:56 +0200 |
commit | 7c1f645e27038eb12e2e46ea0103cc04c96edbb8 (patch) | |
tree | 4624c34cec0b0477dd0cf4fc9181163e17373d19 /Ports/patch | |
parent | bd7d4513bfcc250c472c84365649f522b074816f (diff) | |
download | serenity-7c1f645e27038eb12e2e46ea0103cc04c96edbb8.zip |
Kernel/Net: Iron out the locking mechanism across the subsystem
There is a big mix of LockRefPtrs all over the Networking subsystem, as
well as lots of room for improvements with our locking patterns, which
this commit will not pursue, but will give a good start for such work.
To deal with this situation, we change the following things:
- Creating instances of NetworkAdapter should always yield a non-locking
NonnullRefPtr. Acquiring an instance from the NetworkingManagement
should give a simple RefPtr,as giving LockRefPtr does not really
protect from concurrency problems in such case.
- Since NetworkingManagement works with normal RefPtrs we should
protect all instances of RefPtr<NetworkAdapter> with SpinlockProtected
to ensure references are gone unexpectedly.
- Protect the so_error class member with a proper spinlock. This happens
to be important because the clear_so_error() method lacked any proper
locking measures. It also helps preventing a possible TOCTOU when we
might do a more fine-grained locking in the Socket code, so this could
be definitely a start for this.
- Change unnecessary LockRefPtr<PacketWithTimestamp> in the structure
of OutgoingPacket to a simple RefPtr<PacketWithTimestamp> as the whole
list should be MutexProtected.
Diffstat (limited to 'Ports/patch')
0 files changed, 0 insertions, 0 deletions