summaryrefslogtreecommitdiff
path: root/Ports/cmake/patches/ReadMe.md
diff options
context:
space:
mode:
authorAli Mohammad Pur <ali.mpfard@gmail.com>2022-01-12 23:15:00 +0330
committerAli Mohammad Pur <Ali.mpfard@gmail.com>2022-01-16 10:32:50 +0330
commitf81e28039b8724503669739946df678a77740929 (patch)
treeb34c81619888d01ac834ce696fda3d6e7b9fde28 /Ports/cmake/patches/ReadMe.md
parenta906ff5884ded8345a62bcec76387a64ed56a4fb (diff)
downloadserenity-f81e28039b8724503669739946df678a77740929.zip
Ports: Regenerate the CMake port patches
Diffstat (limited to 'Ports/cmake/patches/ReadMe.md')
-rw-r--r--Ports/cmake/patches/ReadMe.md50
1 files changed, 33 insertions, 17 deletions
diff --git a/Ports/cmake/patches/ReadMe.md b/Ports/cmake/patches/ReadMe.md
index 030d32867c..8b2b218a5c 100644
--- a/Ports/cmake/patches/ReadMe.md
+++ b/Ports/cmake/patches/ReadMe.md
@@ -1,70 +1,86 @@
-# Patches for CMake (and submodules) on SerenityOS
+# Patches for cmake on SerenityOS
## `0001-cmnghttp2-check-for-HAVE_SIZEOF_SSIZE_T-and-not-HAVE.patch`
-Fixes an issue where the first configure of cmake would generate an invalid config.h file somewhere, leading to the first run of `./package.sh` failing due to what `0016-conflicting-0.patch` and `0017-conflicting-1.patch` attempt to fix.
+cmnghttp2: check for HAVE_SIZEOF_SSIZE_T and not HAVE_SSIZE_T
+
+The `check_size_type(ssize_t SIZEOF_SSIZE_T` call in cmcurl (referenced
+by the comment above, which also references some other variables that
+no longer seem to be used) defines HAVE_SIZEOF_SSIZE_T and not
+HAVE_SSIZE_T.
+The HAVE_SSIZE_T variable *does* get defined, but via the
+`CHECK_SIZE_TYPE(ssize_t SSIZE_T)` call in cmlibarchive, which gets
+configured *after* cmnghttp2, and so the first configure leads to an
+invalid cmnghttp2/config.h file.
-### Status
- [ ] Local?
- [X] Should be merged to upstream?
- [ ] Resolves issues(s) with our side of things
- [ ] Hack
-## `0010-don-t-use-siginfo.patch`
+## `0002-kwsys-Don-t-use-siginfo.patch`
+
+kwsys: Don't use siginfo
We don't support SIGINFO. This patch removes uses of SIGINFO.
-### Status
- [X] Local?
- [ ] Should be merged to upstream?
- [X] Resolves issue(s) with our side of things
- [ ] Hack
-## `0012-bin-bash.patch`
+## `0003-bin-bash.patch`
+
+/bin/bash
-This patch swaps out `/bin/sh` for `/bin/bash` in two scripts that need it.
+This patch swaps out /bin/sh for /bin/bash in two scripts that need it.
-### Status
- [X] Local?
- [ ] Should be merged to upstream?
- [ ] Resolves issue(s) with our side of things
- [ ] Hack
-## `0013-platform-serenityos.patch`
+## `0004-Platform-SerenityOS.patch`
+
+Platform/SerenityOS
+
This patch adds the SerenityOS platform config file to CMake.
-### Status
- [ ] Local?
- [X] Should be merged to upstream? If we want to have cmake support serenity out of the box.
- [ ] Resolves issue(s) with our side of things
- [ ] Hack
-## `0014-cmcurl-include-unistd.patch`
+## `0005-cmcurl-Include-unistd.patch`
+
+cmcurl: Include unistd
Everyone gets this wrong. most platforms are very lax with these includes, but we're not one of them.
-### Status
- [X] Local?
- [ ] Should be merged to upstream?
- [ ] Resolves issue(s) with our side of things
- [ ] Hack
-## `0026-curl-struct-stat.patch`
+## `0006-cmcurl-Use-struct-stat-and-include-sys-stat.h.patch`
+
+cmcurl: Use struct stat and include sys/stat.h
-For unknown reasons, `curl_setup_once.h` does not include `sys/stat.h`. this patch includes `sys/stat.h`.
+For unknown reasons, curl_setup_once.h does not include sys/stat.h. this patch includes sys/stat.h.
-### Status
- [ ] Local?
- [ ] Should be merged to upstream?
- [X] Resolves issue(s) with our side of things
- [X] Hack
-## `0028-cmake-disable-tests.patch`
+## `0007-CMake-Disable-tests.patch`
+
+CMake: Disable tests
We don't care about building tests for now, and it makes the compilation much faster.
-### Status
- [ ] Local?
- [ ] Should be merged to upstream?
- [ ] Resolves issue(s) with our side of things
- [ ] Hack
+