diff options
| author | Linus Groh <mail@linusgroh.de> | 2021-04-28 23:48:05 +0200 |
|---|---|---|
| committer | Linus Groh <mail@linusgroh.de> | 2021-04-29 00:59:26 +0200 |
| commit | da72c6987feb00026a8997a5b75f5d493292c7f4 (patch) | |
| tree | 7e0e605071922b6a388ee0b8c57ed6618e466f57 /Meta | |
| parent | 45f97e577ec7890fb3bf35f87e813824acd88597 (diff) | |
| download | serenity-da72c6987feb00026a8997a5b75f5d493292c7f4.zip | |
Meta: Make copyright header check more strict
Diffstat (limited to 'Meta')
| -rwxr-xr-x | Meta/check-style.sh | 23 |
1 files changed, 15 insertions, 8 deletions
diff --git a/Meta/check-style.sh b/Meta/check-style.sh index b933ceb001..1151bd03f8 100755 --- a/Meta/check-style.sh +++ b/Meta/check-style.sh @@ -3,11 +3,16 @@ script_path=$(cd -P -- "$(dirname -- "$0")" && pwd -P) cd "$script_path/.." || exit 1 -# We simply check if the file starts with: +# Ensure copyright headers match this format: # /* -# * Copyright -LICENSE_HEADER_PATTERN=$'^([^\n]*\n)?/\*\n \* Copyright' -MISSING_LICENSE_HEADER_ERRORS=() +# * Copyright (c) YYYY(-YYYY), Whatever +# * ... more of these ... +# * +# * SPDX-License-Identifier: BSD-2-Clause +# */ +GOOD_LICENSE_HEADER_PATTERN=$'^/\*\n( \* Copyright \(c\) [0-9]{4}(-[0-9]{4})?, .*\n)+ \*\n \* SPDX-License-Identifier: BSD-2-Clause\n \*/\n' +BAD_LICENSE_HEADER_ERRORS=() +LICENSE_HEADER_CHECK_EXCUDES=(AK/Checked.h AK/Function.h Userland/Libraries/LibC/elf.h) # We check that "#pragma once" is present PRAGMA_ONCE_PATTERN='#pragma once' @@ -23,8 +28,10 @@ LIBM_MATH_H_INCLUDE_ERRORS=() while IFS= read -r f; do file_content="$(< "$f")" - if [[ ! "$file_content" =~ $LICENSE_HEADER_PATTERN ]]; then - MISSING_LICENSE_HEADER_ERRORS+=("$f") + if [[ ! "${LICENSE_HEADER_CHECK_EXCUDES[*]} " =~ $f ]]; then + if [[ ! "$file_content" =~ $GOOD_LICENSE_HEADER_PATTERN ]]; then + BAD_LICENSE_HEADER_ERRORS+=("$f") + fi fi if [[ "$file_content" =~ $LIBM_MATH_H_INCLUDE_PATTERN ]]; then LIBM_MATH_H_INCLUDE_ERRORS+=("$f") @@ -44,8 +51,8 @@ done < <(git ls-files -- \ ) exit_status=0 -if (( ${#MISSING_LICENSE_HEADER_ERRORS[@]} )); then - echo "Files missing license headers: ${MISSING_LICENSE_HEADER_ERRORS[*]}" +if (( ${#BAD_LICENSE_HEADER_ERRORS[@]} )); then + echo "Files with missing or incorrect license header: ${BAD_LICENSE_HEADER_ERRORS[*]}" exit_status=1 fi if (( ${#MISSING_PRAGMA_ONCE_ERRORS[@]} )); then |