summaryrefslogtreecommitdiff
path: root/Meta/screenshot-000ccc0.png
diff options
context:
space:
mode:
authorLinus Groh <mail@linusgroh.de>2020-05-18 00:28:00 +0100
committerAndreas Kling <kling@serenityos.org>2020-05-18 09:39:55 +0200
commit476094922b6dbbc252a076aecca9cc0d172e540e (patch)
treedadd0976793ea60541d74c82f3531ab6b38a4dc8 /Meta/screenshot-000ccc0.png
parent1a1394f7a2f17bb0631cc4aaaa9c78f0cf700312 (diff)
downloadserenity-476094922b6dbbc252a076aecca9cc0d172e540e.zip
LibJS: Pass Interpreter& to Value::to_number() et al.
This patch is unfortunately rather large and might make some things feel bloated, but it is necessary to fix a few flaws in LibJS, primarily blindly coercing values to numbers without exception checks - i.e. interpreter.argument(0).to_i32(); // can fail!!! Some examples where the interpreter would actually crash: var o = { toString: () => { throw Error() } }; +o; o - 1; "foo".charAt(o); "bar".repeat(o); To fix this, we now have the following... to_double(Interpreter&) to_i32() to_i32(Interpreter&) to_size_t() to_size_t(Interpreter&) ...and a whole lot of exception checking. There's intentionally no to_double(), use as_double() directly instead. This way we still can use these convenient utility functions but don't need to check for exceptions if we are sure the value already is a number. Fixes #2267.
Diffstat (limited to 'Meta/screenshot-000ccc0.png')
0 files changed, 0 insertions, 0 deletions