diff options
| author | Shannon Booth <shannon.ml.booth@gmail.com> | 2020-02-10 19:09:08 +1300 |
|---|---|---|
| committer | Andreas Kling <kling@serenityos.org> | 2020-02-10 10:46:25 +0100 |
| commit | fe668db9995b978e96b76e53cb462b508a5f242a (patch) | |
| tree | b6608298b0a1ffc0b187db0500aba4b9c47b9508 /Meta/refresh-serenity-qtcreator.sh | |
| parent | e9be8669d29cdee6ae51be3b31b54ca0f3d3a1d1 (diff) | |
| download | serenity-fe668db9995b978e96b76e53cb462b508a5f242a.zip | |
Meta: Fix shellcheck warnings in various scripts
Warnings fixed:
* SC2086: Double quote to prevent globbing and word splitting.
* SC2006: Use $(...) notation instead of legacy backticked `...`
* SC2039: In POSIX sh, echo flags are undefined
* SC2209: Use var=$(command) to assign output (or quote to assign string)
* SC2164: Use 'cd ... || exit' or 'cd ... || return' in case cd fails
* SC2166: Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
* SC2034: i appears unused. Verify use (or export if used externally)
* SC2046: Quote this to prevent word splitting.
* SC2236: Use -z instead of ! -n.
There are still a lot of warnings in Kernel/run about:
- SC2086: Double quote to prevent globbing and word splitting.
However, splitting on space is intentional in this case, and not trivial to
change. Therefore ignore the warning for now - but we should fix this in
the future.
Diffstat (limited to 'Meta/refresh-serenity-qtcreator.sh')
| -rwxr-xr-x | Meta/refresh-serenity-qtcreator.sh | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/Meta/refresh-serenity-qtcreator.sh b/Meta/refresh-serenity-qtcreator.sh index 0ddc7a1636..efd0d5cf52 100755 --- a/Meta/refresh-serenity-qtcreator.sh +++ b/Meta/refresh-serenity-qtcreator.sh @@ -1,6 +1,6 @@ #!/bin/sh -if [ ! -n "$SERENITY_ROOT" ] +if [ -z "$SERENITY_ROOT" ] then echo "Serenity root not set. Please set environment variable first. E.g. export SERENITY_ROOT=$(git rev-parse --show-toplevel)" fi |