diff options
author | Brian Gianforcaro <bgianf@serenityos.org> | 2021-05-04 21:46:18 -0700 |
---|---|---|
committer | Andreas Kling <kling@serenityos.org> | 2021-05-05 21:26:37 +0200 |
commit | 8b856bd5a12f0d9edbdea60916900fd3f7f40823 (patch) | |
tree | 068b5a6d15bfa756e7a57ca0642ecff02f369111 /Meta/lint-shell-scripts.sh | |
parent | f558a44610019ca2149ed6e161992ad20f1a9419 (diff) | |
download | serenity-8b856bd5a12f0d9edbdea60916900fd3f7f40823.zip |
Toolchain: Fix expansion bugs and make BuildIt.sh shellcheck compliant
BuildIt.sh had a bunch of SC2086 errors, where we were not quoting
variables in variable expansions. The logic being:
Quoting variables prevents word splitting and glob expansion,
and prevents the script from breaking when input contains spaces,
line feeds, glob characters and such.
Reference: https://github.com/koalaman/shellcheck/wiki/SC2086
As bcoles noticed in #6772, shellcheck actually found a real bug here,
where the user's build directory included spaces.
Close: #6772
Diffstat (limited to 'Meta/lint-shell-scripts.sh')
0 files changed, 0 insertions, 0 deletions