summaryrefslogtreecommitdiff
path: root/Libraries
diff options
context:
space:
mode:
authorAndreas Kling <kling@serenityos.org>2020-06-21 01:00:58 +0200
committerAndreas Kling <kling@serenityos.org>2020-06-21 01:01:50 +0200
commitbc4fa7a3c9ab758ddde34c98a840375aeb0e77a3 (patch)
tree4ebe82e54d328947a54ebc8d89802cf710ba7b23 /Libraries
parentfaff557400a0c6979e82cf22769d9df6f988ed94 (diff)
downloadserenity-bc4fa7a3c9ab758ddde34c98a840375aeb0e77a3.zip
LibWeb: Expose Node.appendChild() to the web
This is a very barebones implementation of appendChild() that doesn't take any of the idiosyncratic DOM behaviors into account yet. Also teach the wrapper generator how to turn an Interpreter argument into a Node&.
Diffstat (limited to 'Libraries')
-rw-r--r--Libraries/LibWeb/CodeGenerators/WrapperGenerator.cpp7
-rw-r--r--Libraries/LibWeb/DOM/Node.cpp6
-rw-r--r--Libraries/LibWeb/DOM/Node.h2
-rw-r--r--Libraries/LibWeb/DOM/Node.idl1
4 files changed, 16 insertions, 0 deletions
diff --git a/Libraries/LibWeb/CodeGenerators/WrapperGenerator.cpp b/Libraries/LibWeb/CodeGenerators/WrapperGenerator.cpp
index 043e2811c8..a1dcd0b860 100644
--- a/Libraries/LibWeb/CodeGenerators/WrapperGenerator.cpp
+++ b/Libraries/LibWeb/CodeGenerators/WrapperGenerator.cpp
@@ -473,6 +473,13 @@ void generate_implementation(const IDL::Interface& interface)
out() << " auto " << snake_name(parameter.name) << " = interpreter.argument(" << argument_index << ").to_string(interpreter);";
out() << " if (interpreter.exception())";
out() << " return {};";
+ } else if (parameter.type.name == "Node") {
+ out() << " auto " << snake_name(parameter.name) << "_object = interpreter.argument(" << argument_index << ").to_object(interpreter, global_object);";
+ out() << " if (interpreter.exception())";
+ out() << " return {};";
+ out() << " if (!" << snake_name(parameter.name) << "_object->is_web_wrapper() || !static_cast<Wrapper*>(" << snake_name(parameter.name) << "_object)->is_node_wrapper())";
+ out() << " return interpreter.throw_exception<JS::TypeError>(JS::ErrorType::NotA, \"" << parameter.type.name << "\");";
+ out() << " auto& " << snake_name(parameter.name) << " = static_cast<" << wrapper_class << "*>(" << snake_name(parameter.name) << "_object)->impl();";
}
++argument_index;
}
diff --git a/Libraries/LibWeb/DOM/Node.cpp b/Libraries/LibWeb/DOM/Node.cpp
index 835cd68d65..0abb77b750 100644
--- a/Libraries/LibWeb/DOM/Node.cpp
+++ b/Libraries/LibWeb/DOM/Node.cpp
@@ -193,4 +193,10 @@ const Element* Node::parent_element() const
return to<Element>(parent());
}
+RefPtr<Node> Node::append_child(NonnullRefPtr<Node> node, bool notify)
+{
+ TreeNode<Node>::append_child(node, notify);
+ return node;
+}
+
}
diff --git a/Libraries/LibWeb/DOM/Node.h b/Libraries/LibWeb/DOM/Node.h
index b0065f39b6..30504abcaf 100644
--- a/Libraries/LibWeb/DOM/Node.h
+++ b/Libraries/LibWeb/DOM/Node.h
@@ -82,6 +82,8 @@ public:
bool is_document_fragment() const { return type() == NodeType::DOCUMENT_FRAGMENT_NODE; }
bool is_parent_node() const { return is_element() || is_document() || is_document_fragment(); }
+ RefPtr<Node> append_child(NonnullRefPtr<Node>, bool notify = true);
+
virtual RefPtr<LayoutNode> create_layout_node(const StyleProperties* parent_style) const;
virtual FlyString node_name() const = 0;
diff --git a/Libraries/LibWeb/DOM/Node.idl b/Libraries/LibWeb/DOM/Node.idl
index 2fca1a6d8e..3bb148197d 100644
--- a/Libraries/LibWeb/DOM/Node.idl
+++ b/Libraries/LibWeb/DOM/Node.idl
@@ -8,5 +8,6 @@ interface Node : EventTarget {
readonly attribute Node? parentNode;
readonly attribute Element? parentElement;
+ Node appendChild(Node node);
}