Everywhere: Switch from (void) to [[maybe_unused]] (#4473)

Problem:
- `(void)` simply casts the expression to void. This is understood to
  indicate that it is ignored, but this is really a compiler trick to
  get the compiler to not generate a warning.

Solution:
- Use the `[[maybe_unused]]` attribute to indicate the value is unused.

Note:
- Functions taking a `(void)` argument list have also been changed to
  `()` because this is not needed and shows up in the same grep
  command.

1 files changed, 2 insertions, 6 deletions

diff --git a/Libraries/LibC/ulimit.cpp b/Libraries/LibC/ulimit.cpp
index 8bff47a578..0bd284c538 100644
--- a/Libraries/LibC/ulimit.cpp
+++ b/Libraries/LibC/ulimit.cpp
@@ -31,18 +31,14 @@
 
 extern "C" {
 
-long ulimit(int cmd, long newlimit)
+long ulimit([[maybe_unused]] int cmd, [[maybe_unused]] long newlimit)
 {
-    (void)cmd;
-    (void)newlimit;
     ASSERT_NOT_REACHED();
     return -1;
 }
 
-int getrusage(int who, struct rusage* usage)
+int getrusage([[maybe_unused]] int who, [[maybe_unused]] struct rusage* usage)
 {
-    (void)who;
-    (void)usage;
     dbg() << "LibC: getrusage is not implemented";
     return -1;
 }