summaryrefslogtreecommitdiff
path: root/Ladybird
diff options
context:
space:
mode:
authorAaron Dewes <aaron.dewes@protonmail.com>2022-09-21 21:17:13 +0200
committerAndrew Kaster <andrewdkaster@gmail.com>2022-12-25 07:58:58 -0700
commitbdce860ac53116fcc611242fc9ac85fd03608ce7 (patch)
tree0439b3e17cd709fb7c3563c90f4f0e8be9c7ed6d /Ladybird
parent445cc7c97d73cab09f87618fa4e72bd60b1c6e58 (diff)
downloadserenity-bdce860ac53116fcc611242fc9ac85fd03608ce7.zip
Ladybird: Make Tab.cpp directly take a BrowserWindows as m_window
Diffstat (limited to 'Ladybird')
-rw-r--r--Ladybird/Tab.cpp7
-rw-r--r--Ladybird/Tab.h6
2 files changed, 6 insertions, 7 deletions
diff --git a/Ladybird/Tab.cpp b/Ladybird/Tab.cpp
index a539ee9c13..1f6fedb44d 100644
--- a/Ladybird/Tab.cpp
+++ b/Ladybird/Tab.cpp
@@ -18,7 +18,7 @@
extern String s_serenity_resource_root;
extern Browser::Settings* s_settings;
-Tab::Tab(QMainWindow* window)
+Tab::Tab(BrowserWindow* window)
: m_window(window)
{
m_layout = new QBoxLayout(QBoxLayout::Direction::TopToBottom, this);
@@ -146,10 +146,7 @@ void Tab::page_favicon_changed(QIcon icon)
int Tab::tab_index()
{
- // FIXME: I hear you like footguns...
- // There has to be a better way of doing this
- auto browser_window = reinterpret_cast<BrowserWindow*>(m_window);
- return browser_window->tab_index(this);
+ return m_window->tab_index(this);
}
void Tab::debug_request(String const& request, String const& argument)
diff --git a/Ladybird/Tab.h b/Ladybird/Tab.h
index b6f6bf8830..3a8373335d 100644
--- a/Ladybird/Tab.h
+++ b/Ladybird/Tab.h
@@ -17,10 +17,12 @@
#include <QToolBar>
#include <QWidget>
+class BrowserWindow;
+
class Tab final : public QWidget {
Q_OBJECT
public:
- explicit Tab(QMainWindow* window);
+ explicit Tab(BrowserWindow* window);
WebView& view() { return *m_view; }
@@ -51,7 +53,7 @@ private:
QToolBar* m_toolbar { nullptr };
QLineEdit* m_location_edit { nullptr };
WebView* m_view { nullptr };
- QMainWindow* m_window { nullptr };
+ BrowserWindow* m_window { nullptr };
Browser::History m_history;
QString m_title;
QLabel* m_hover_label { nullptr };