diff options
author | Andreas Kling <kling@serenityos.org> | 2021-11-21 12:26:12 +0100 |
---|---|---|
committer | Andreas Kling <kling@serenityos.org> | 2021-11-21 20:22:48 +0100 |
commit | e1779b064a8f8967ee11bf3dacff453b426f59fa (patch) | |
tree | 168ae406ec3edf5cdb359ed93e41782aa2043de4 /Kernel | |
parent | f2c3a41a8f8dab3ccd46b91f52a351a9a855879c (diff) | |
download | serenity-e1779b064a8f8967ee11bf3dacff453b426f59fa.zip |
Kernel: Remove bogus TODO in coredump generation
When dumping the memory contents of a process, we should not page in
things from inodes that were not already paged in.
Diffstat (limited to 'Kernel')
-rw-r--r-- | Kernel/Coredump.cpp | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/Kernel/Coredump.cpp b/Kernel/Coredump.cpp index 7d94784be2..85fda720fd 100644 --- a/Kernel/Coredump.cpp +++ b/Kernel/Coredump.cpp @@ -186,8 +186,6 @@ ErrorOr<void> Coredump::write_regions() if (page) return UserOrKernelBuffer::for_user_buffer(reinterpret_cast<uint8_t*>((region->vaddr().as_ptr() + (i * PAGE_SIZE))), PAGE_SIZE); // If the current page is not backed by a physical page, we zero it in the coredump file. - // TODO: Do we want to include the contents of pages that have not been faulted-in in the coredump? - // (A page may not be backed by a physical page because it has never been faulted in when the process ran). return UserOrKernelBuffer::for_kernel_buffer(zero_buffer); }(); TRY(m_description->write(src_buffer.value(), PAGE_SIZE)); |