Kernel: mknod() should not allow unprivileged users to create devices

In fact, unless you are superuser, you may only create a regular file,
a named pipe, or a local domain socket. Anything else should EPERM.

1 files changed, 5 insertions, 0 deletions

diff --git a/Kernel/Process.cpp b/Kernel/Process.cpp
index f5532c696a..39c3f68df2 100644
--- a/Kernel/Process.cpp
+++ b/Kernel/Process.cpp
@@ -3478,6 +3478,11 @@ int Process::sys$mknod(const char* pathname, mode_t mode, dev_t dev)
     if (!validate_read_str(pathname))
         return -EFAULT;
 
+    if (!is_superuser()) {
+        if (!is_regular_file(mode) && !is_fifo(mode) && !is_socket(mode))
+            return -EPERM;
+    }
+
     return VFS::the().mknod(StringView(pathname), mode, dev, current_directory());
 }