diff options
author | Andreas Kling <kling@serenityos.org> | 2021-09-05 17:55:43 +0200 |
---|---|---|
committer | Andreas Kling <kling@serenityos.org> | 2021-09-05 17:55:43 +0200 |
commit | 4e4b7c272c88b32f127bbb0970e659ac5d04754f (patch) | |
tree | f412f5ee020e6c9b17e53faf7e5cd5ae70daeb33 /Kernel | |
parent | e0cf9152ca842900a20962a45b72ad51c443da18 (diff) | |
download | serenity-4e4b7c272c88b32f127bbb0970e659ac5d04754f.zip |
Kernel: Use TRY() in sys$readlink()
Diffstat (limited to 'Kernel')
-rw-r--r-- | Kernel/Syscalls/readlink.cpp | 22 |
1 files changed, 6 insertions, 16 deletions
diff --git a/Kernel/Syscalls/readlink.cpp b/Kernel/Syscalls/readlink.cpp index 0a9c246041..21b4a570fd 100644 --- a/Kernel/Syscalls/readlink.cpp +++ b/Kernel/Syscalls/readlink.cpp @@ -16,27 +16,17 @@ KResultOr<FlatPtr> Process::sys$readlink(Userspace<const Syscall::SC_readlink_pa REQUIRE_PROMISE(rpath); auto params = TRY(copy_typed_from_user(user_params)); - auto path = get_syscall_path_argument(params.path); - if (path.is_error()) - return path.error(); - - auto result = VirtualFileSystem::the().open(path.value()->view(), O_RDONLY | O_NOFOLLOW_NOERROR, 0, current_directory()); - if (result.is_error()) - return result.error(); - auto description = result.value(); + auto path = TRY(get_syscall_path_argument(params.path)); + auto description = TRY(VirtualFileSystem::the().open(path->view(), O_RDONLY | O_NOFOLLOW_NOERROR, 0, current_directory())); if (!description->metadata().is_symlink()) return EINVAL; - auto contents = description->read_entire_file(); - if (contents.is_error()) - return contents.error(); - - auto& link_target = *contents.value(); - auto size_to_copy = min(link_target.size(), params.buffer.size); - TRY(copy_to_user(params.buffer.data, link_target.data(), size_to_copy)); + auto link_target = TRY(description->read_entire_file()); + auto size_to_copy = min(link_target->size(), params.buffer.size); + TRY(copy_to_user(params.buffer.data, link_target->data(), size_to_copy)); // Note: we return the whole size here, not the copied size. - return link_target.size(); + return link_target->size(); } } |