summaryrefslogtreecommitdiff
path: root/Kernel
diff options
context:
space:
mode:
authorAndrew Kaster <akaster@serenityos.org>2021-11-14 15:48:27 -0700
committerAndreas Kling <kling@serenityos.org>2021-11-16 00:13:22 +0100
commit194456efdcdeb67c34a9e255385c777ea411b308 (patch)
tree00059da015edfefeacb8b3c4bdb0705ace72472d /Kernel
parentcca4268ff84b7abd09b04db4f8d73cbdf960110c (diff)
downloadserenity-194456efdcdeb67c34a9e255385c777ea411b308.zip
Kernel: Remove unnecessary StringBuilder from sys$create_thread()
A series of refactors changed Threads to always have a name, and to store their name as a KString. Before the refactors a StringBuilder was used to format the default thread name for a non-main thread, but it is since unused. Remove it and the AK/String related header includes from the thread syscall implementation file.
Diffstat (limited to 'Kernel')
-rw-r--r--Kernel/Syscalls/thread.cpp9
1 files changed, 2 insertions, 7 deletions
diff --git a/Kernel/Syscalls/thread.cpp b/Kernel/Syscalls/thread.cpp
index 9c0f5715ae..f32fe56e8c 100644
--- a/Kernel/Syscalls/thread.cpp
+++ b/Kernel/Syscalls/thread.cpp
@@ -5,8 +5,6 @@
*/
#include <AK/Checked.h>
-#include <AK/String.h>
-#include <AK/StringBuilder.h>
#include <Kernel/Memory/MemoryManager.h>
#include <Kernel/PerformanceManager.h>
#include <Kernel/Process.h>
@@ -43,13 +41,10 @@ ErrorOr<FlatPtr> Process::sys$create_thread(void* (*entry)(void*), Userspace<con
auto thread = TRY(Thread::try_create(*this));
- // FIXME: Don't make a temporary String here
- auto new_thread_name = TRY(KString::try_create(String::formatted("{} [{}]", m_name, thread->tid().value())));
-
// We know this thread is not the main_thread,
// So give it a unique name until the user calls $set_thread_name on it
- // length + 4 to give space for our extra junk at the end
- StringBuilder builder(m_name->length() + 4);
+ // FIXME: Don't make a temporary String here
+ auto new_thread_name = TRY(KString::try_create(String::formatted("{} [{}]", m_name, thread->tid().value())));
thread->set_name(move(new_thread_name));
if (!is_thread_joinable)