Kernel: Mark UserOrKernelBuffer and it's getters as [[nodicard]]

`UserOrKernelBuffer` objects should always be observed when created, in
turn there is no reason to call a getter without observing the result.
Doing either of these indicates an error in the code. Mark these methods
as [[nodiscard]] to find these cases.

1 files changed, 5 insertions, 5 deletions

diff --git a/Kernel/UserOrKernelBuffer.h b/Kernel/UserOrKernelBuffer.h
index a6280f0254..9bbbfc21aa 100644
--- a/Kernel/UserOrKernelBuffer.h
+++ b/Kernel/UserOrKernelBuffer.h
@@ -36,7 +36,7 @@
 
 namespace Kernel {
 
-class UserOrKernelBuffer {
+class [[nodiscard]] UserOrKernelBuffer {
 public:
     UserOrKernelBuffer() = delete;
 
@@ -61,10 +61,10 @@ public:
         return UserOrKernelBuffer(const_cast<u8*>((const u8*)userspace.unsafe_userspace_ptr()));
     }
 
-    bool is_kernel_buffer() const;
-    const void* user_or_kernel_ptr() const { return m_buffer; }
+    [[nodiscard]] bool is_kernel_buffer() const;
+    [[nodiscard]] const void* user_or_kernel_ptr() const { return m_buffer; }
 
-    UserOrKernelBuffer offset(ssize_t offset) const
+    [[nodiscard]] UserOrKernelBuffer offset(ssize_t offset) const
     {
         if (!m_buffer)
             return *this;
@@ -74,7 +74,7 @@ public:
         return offset_buffer;
     }
 
-    String copy_into_string(size_t size) const;
+    [[nodiscard]] String copy_into_string(size_t size) const;
     [[nodiscard]] bool write(const void* src, size_t offset, size_t len);
     [[nodiscard]] bool write(const void* src, size_t len)
     {