diff options
| author | Brian Gianforcaro <bgianf@serenityos.org> | 2021-12-29 00:10:17 -0800 |
|---|---|---|
| committer | Andreas Kling <kling@serenityos.org> | 2021-12-29 18:08:15 +0100 |
| commit | bad6d50b86ae1e0a46219baf149fa0a3574af9ce (patch) | |
| tree | 83d0da5a800509416d70555b751cd01244cbe98c /Kernel/Syscalls/poll.cpp | |
| parent | c4f60844c5d2bd51e70a621753208fe0c9392339 (diff) | |
| download | serenity-bad6d50b86ae1e0a46219baf149fa0a3574af9ce.zip | |
Kernel: Use Process::require_promise() instead of REQUIRE_PROMISE()
This change lays the foundation for making the require_promise return
an error hand handling the process abort outside of the syscall
implementations, to avoid cases where we would leak resources.
It also has the advantage that it makes removes a gs pointer read
to look up the current thread, then process for every syscall. We
can instead go through the Process this pointer in most cases.
Diffstat (limited to 'Kernel/Syscalls/poll.cpp')
| -rw-r--r-- | Kernel/Syscalls/poll.cpp | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/Kernel/Syscalls/poll.cpp b/Kernel/Syscalls/poll.cpp index 670a1fa2a7..946929fc8b 100644 --- a/Kernel/Syscalls/poll.cpp +++ b/Kernel/Syscalls/poll.cpp @@ -17,7 +17,8 @@ using BlockFlags = Thread::FileBlocker::BlockFlags; ErrorOr<FlatPtr> Process::sys$poll(Userspace<const Syscall::SC_poll_params*> user_params) { VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) - REQUIRE_PROMISE(stdio); + require_promise(Pledge::stdio); + auto params = TRY(copy_typed_from_user(user_params)); if (params.nfds >= OpenFileDescriptions::max_open()) |